[CLOSED] Fix issue #1240 (Inline editor background width)

[core-ai-bot]

Issue by peterflynn
Tuesday Jul 17, 2012 at 07:11 GMT
Originally opened as adobe/brackets#1264

---

Fix issue #1240 (Inline editor background doesn't extend all the way to right when scrolling)

CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's content is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number.

See the bug for slightly more detail.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/1264/commits

[core-ai-bot]

Comment by redmunds
Tuesday Jul 17, 2012 at 16:35 GMT

---

reviewing

[core-ai-bot]

Comment by redmunds
Tuesday Jul 17, 2012 at 16:45 GMT

---

Yes, this fixes the issue captured in #1240, but I am seeing another issue:

1. open any file that requires a horizontal scroll (e.g. brackets/src/index.html)
2. select 1 or more lines of text
   >> notice that the selection does not extend all the way to the right
3. scroll horizontally to the right
   >> selection gap on right gets even bigger

Is that related to this fix, or should I log a new issue?

[core-ai-bot]

Comment by peterflynn
Tuesday Jul 17, 2012 at 20:06 GMT

---

@redmunds: yes, please log a new issue. Looks like that bug is also due to the CodeMirror merge this sprint, but it's unrelated to the fix here (in fact it repros even in a vanilla CodeMirror build from upstream, without any Brackets stuff at all).

[core-ai-bot]

Comment by redmunds
Tuesday Jul 17, 2012 at 20:11 GMT

---

New issue #1267 logged for problem described above

[core-ai-bot]

Comment by redmunds
Tuesday Jul 17, 2012 at 20:12 GMT

---

This fix looks good.