[Live preview] Changing preferences in brackets.json causes the LP to close

[core-ai-bot]

Issue by Worie
Thursday Apr 06, 2017 at 12:57 GMT
Originally opened as adobe/brackets#13275

---

Description

During implementation of adobe/brackets#12949 (review) i've created a piece of code that'd allow the user to change the livedev.remoteHighlight without breaking the Live Preview session (so that user can experiment easier with customization of remoteHighlight).

Meanwhile, changes made in adobe/brackets@d6ae906 to LiveDevelopment/main.js (adobe/brackets@d6ae906#diff-71eea40ea29ec83062c1151ff5ee0dc2) caused that changing any part of brackets.json closes the LivePreview.

Steps to Reproduce

1. Open live preview on some file.
2. Change any part of brackets.json
3. Live preview is closed without any explicit message.

What I suggest is that we should either provide a meaningful message to the user, that he cannot change preferences while LP is active (otherwise it closes) and remove unnecessary code (updateConfig in RemoteFunctions.js and change listener on some preferences in LiveDevelopment/main.js) or reenable the ability to change brackets.json file while LP is open without closing it.