[CLOSED] Stop using flexbox in editor's parent hierarchy #1801
Comments
|
Randy noticed a bug when you use the show/hide sidebar toggle. I have a fix that I'll incorporate along with the first round of code review changes -- so don't actually merge this yet. |
|
Done with initial review. |
|
Fixes pushed. This fixes the bug Randy spotted and one more I found (see commit comments), plus code review feedback. |
|
Done reviewing. Just 1 minor question about a comment. |
|
|
|
Looks good. Merging. |
|
Thanks! (Also thanks to |
Tuesday Oct 16, 2012 at 01:31 GMT
Originally opened as adobe/brackets#1847
Noticeably improves performance when scrolling, dragging selections, etc.
Should fix bugs #1354 and adobe/brackets-shell#61.
Many thanks to
@chicu123 for suggesting this as a performance bottleneck (and@jasonsanjose for confirming by noting suspicious repaint regions). Test data from Alex's original proof-of-concept patch suggest this change may improve typing performance by 1/3 and nearly double scrolling framerate!So, the two wrinkles with this are:
Vertical layout
Without flexbox, you'd typically have to do the equivalent vertical layout programmatically with JS -- which is no problem in this case since CodeMirror needs to get a JS call anyway each time the editor's height changes. So all that's really needed is code to calculate the desired editor height, since we can't just measure its flex container any more.
Horizontal layout
The horizontal layout of the sidebar + content area (the vertical toolbar/editor/panels stack) used to use a horizontal flexbox. It now uses 'float: left' for the sidebar and an equivalent margin on the content stack. The margin is needed since non-floated boxes actually underlap their floated siblings (only the flowed content inside them is actually pushed inward). This would have caused several problems: CodeMirror's mouse handling blocked the sidebar, and 'position: relative' items like the toolbar would have drawn on top of the sidebar.
peterflynn included the following code: https://github.com/adobe/brackets/pull/1847/commits
The text was updated successfully, but these errors were encountered: