Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Make mode string in statusbar more presentable #1872

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] Make mode string in statusbar more presentable #1872

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Tuesday Oct 23, 2012 at 22:48 GMT
Originally opened as adobe/brackets#1923

This is for #1826

This fixes exception with many modes such as JSON. Mode can be either a string or an Object with a name property, but it was assumed to be a string.

Handled as a special case: JavaScript, HTML, CSS. Any others we should handle?

For remaining cases, we strip "/" and everything after it, and then capitalize what's left. Most of these are simply "Text".

redmunds included the following code: https://github.com/adobe/brackets/pull/1923/commits
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Oct 24, 2012 at 03:37 GMT

Done with initial review.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Oct 24, 2012 at 18:17 GMT

Changes. Pushed.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Oct 24, 2012 at 19:02 GMT

Done reviewing the additional changes.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Oct 24, 2012 at 20:34 GMT

Done with changes for code review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot