[CLOSED] Indent/tab size sporadically reset to 1 - due to unit test?

[core-ai-bot]

Issue by peterflynn
Saturday Jan 19, 2013 at 01:26 GMT
Originally opened as adobe/brackets#2612

---

@gruehle and I both recently had our indent size setting suddenly change to 1 (from our usual 4) with no warning. We're not sure why.

@zoufahl noted that his CSS code hinting unit tests manually set it to 1. Looking at the unit test code, they're definitely doing it in a way that could break other unit tests -- the setting is changed as soon as the test module loads (even if it's never run), and it's never reset later. But it doesn't readily affect the main Brackets window, even if I explicitly run the test.

It's likely the cause anyway, but I'm just not sure how (and/or what circumstances will make it repro).

If it's the unit test though, this luckily won't affect installer builds, since those exclude all unit test code.

[core-ai-bot]

Comment by zoufahl
Saturday Jan 19, 2013 at 12:46 GMT

---

I think for now this piece of code can be removed.
I initially put it there to simulate users pressing 'Tab' without changing my testdocuments (and also I didn't wanted to guess the users indent size).
Since this feature isn't used at all in the unittests so far, it's save to remove it (for now).

[core-ai-bot]

Comment by njx
Monday Jan 28, 2013 at 19:06 GMT

---

Reviewed. To@dangoor for Sprint 20.

[core-ai-bot]

Comment by RaymondLim
Wednesday Jan 30, 2013 at 18:35 GMT

---

FBNC to@peterflynn

[core-ai-bot]

Comment by peterflynn
Wednesday Jan 30, 2013 at 19:20 GMT

---

I don't really have a means to verify since Glenn and I each only hit this once and weren't able to repro it. Closing, and I'll just reopen if anyone sees this again.

[core-ai-bot]

Comment by njx
Wednesday Jan 30, 2013 at 19:40 GMT

---

I also hit it once. Will reopen if I see it again, but it's hard to imagine it would happen again after@dangoor's fix.