[CLOSED] Cleaner fix for #2761 (Project tree selection incorrect after opening file by means other than sidebar)

[core-ai-bot]

Issue by peterflynn
Wednesday Apr 10, 2013 at 08:15 GMT
Originally opened as adobe/brackets#3398

---

Cleaner fix for #2761 -- Clear selection in project tree if current document not exposed in tree anywhere.

Backs out pull #2869, which made the behavior of Find in Files inconsistent with other means of opening files and didn't fix other cases of the bug.

Adds unit tests for several of these edge cases.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/3398/commits

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 10, 2013 at 08:16 GMT

---

@redmunds since you were the reviewer of the original #2869 would you be able to review this one too?

[core-ai-bot]

Comment by redmunds
Wednesday Apr 10, 2013 at 15:02 GMT

---

I guess I misinterpreted your "Ideally, file B would become selected in the project tree if it's exposed" comment in the bug report, but you're right that none of the other tools do that. Reviewing...

[core-ai-bot]

Comment by redmunds
Wednesday Apr 10, 2013 at 16:46 GMT

---

Done with initial review.

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 10, 2013 at 17:46 GMT

---

@redmunds added a bunch of responses. Let me know if anything more is needed.

Thanks for the review!

[core-ai-bot]

Comment by redmunds
Wednesday Apr 10, 2013 at 18:09 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by redmunds
Wednesday Apr 10, 2013 at 18:19 GMT

---

Opened issue adobe/brackets#3404