[CLOSED] [quick view] Some gradients not yet supported

[core-ai-bot]

Issue by redmunds
Tuesday Apr 16, 2013 at 20:16 GMT
Originally opened as adobe/brackets#3458

---

http://dev.w3.org/csswg/css-images-3/

This applies to both linear-gradient() and radial-gradient() types. There are also new repeating-linear-gradient() and repeating-radial-gradient() types. These formats are supported in the latest Chrome (26), but the version of CEF Brackets is using has Chrome 25.

/* gradients not yet supported */
.not_yet_supported_gradients {

    /* "to" keyword */
    background-image: linear-gradient(to right, #333, #CCC);

    /* non-prefixed radial-gradient() */
    background-image: radial-gradient(yellow, green); 

    /* repeating-linear-gradient() */
    background-image: repeating-linear-gradient(red, blue 20px, red 40px);
    background-image: repeating-linear-gradient(red 0px, white 0px, blue 0px);
    background-image: repeating-linear-gradient(red 0px, white .1px, blue .2px);

    /* repeating-radial-gradient() */
    background-image: repeating-radial-gradient(circle closest-side at 20px 30px, red, yellow, green 100%, yellow 150%, red 200%);
    background-image: repeating-radial-gradient(red, blue 20px, red 40px);
}

[core-ai-bot]

Comment by njx
Monday Apr 22, 2013 at 18:16 GMT

---

Reviewed. Leaving open in sprint 24 to disable hover preview for these gradients. Later on, when we get a CEF that supports them, we should turn this back on. So, once #3482 is merged, let's remove the sprint milestone but leave it open.

[core-ai-bot]

Comment by redmunds
Monday Apr 22, 2013 at 22:02 GMT

---

These gradients are now disabled, so removing sprint 24 milestone.

[core-ai-bot]

Comment by JeffryBooher
Monday Jun 17, 2013 at 16:12 GMT

---

@redmunds The w3 style gradients are still not showing up with CEF3.1453.1255 which is using Chromium version 27.0.1453.73. The Regex isn't capturing the w3 gradient syntax (linear-gradient, repeating-linear-gradient, radial-gradient, repeating-radial-gradient)...

Was there code in a branch somewhere that just needs to be tested? The unit tests for w3 gradients are in master but commented out so it isn't clear where I should be looking.

[core-ai-bot]

Comment by redmunds
Monday Jun 17, 2013 at 17:41 GMT

---

@JeffryBooher The regex has definitely not been updated for the "repeating" formats. I'm not sure if regex needs to be updated for the other new w3 formats.

Note the existing code adds a -webkit- prefix in some w3 cases to get them to render in the current version of Chrome. We might be able to get rid of that to simplify code in some cases. We might need to get rid of that to get them to render in other cases.

Someone added some of the (commented out) units test just because they were easy to add.

[core-ai-bot]

Comment by JeffryBooher
Monday Jun 17, 2013 at 18:59 GMT

---

I tested the 'to' and I think most or all of them are fixed with CEF3.1453.1255; however, code changes need to be made to the QuickView extension to make them work.

[core-ai-bot]

Comment by JeffryBooher
Monday Jun 17, 2013 at 19:00 GMT

---

Taking this one as@redmunds is going on sabbatical soon.

[core-ai-bot]

Comment by redmunds
Thursday Jun 20, 2013 at 00:50 GMT

---

Confirmed. Closing.