Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Larz/project panel text contrast #3651

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

[CLOSED] Larz/project panel text contrast #3651

core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by larz0
Sunday May 19, 2013 at 17:34 GMT
Originally opened as adobe/brackets#3910


@peterflynn@njx let me know what you think. Once it's finalized I'll change the color of the disclosure triangles to match that color.


larz0 included the following code: https://github.com/adobe/brackets/pull/3910/commits

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday May 20, 2013 at 16:05 GMT


See comments in #3501

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday May 21, 2013 at 06:07 GMT


@larz0 The bluish cast looks a lot stronger now that the color is brighter... should we desaturate it a bit?

Also, there are a few Extension Manager UI diffs in this pull request too -- wasn't sure if that was intentional or not?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Tuesday May 21, 2013 at 13:05 GMT


Ok cool I'll see if I can desaturate it a bit without losing carity. That Extension Manager UI diff is probably due to error on my part; I'll remove them.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday May 22, 2013 at 01:20 GMT


@peterflynn left is master, right is this branch:

screen shot 2013-05-21 at 6 18 31 pm

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday May 24, 2013 at 18:30 GMT


@larz0: Nice, looks good to me now! We should merge this whenever master reopens for Sprint 26 fixes (which will hopefully be end of today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant