Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [Core][Invalid filename]: Parameter "{0}" appears in the invalid filename title. #4126

Open
core-ai-bot opened this issue Aug 29, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by julieyuan
Monday Jul 15, 2013 at 05:41 GMT
Originally opened as adobe/brackets#4453


Steps:

  1. Launch Brackets.
  2. New a file or folder.
  3. Then rename this file with invalid charcters, such as : ??//

Results:
It pops up invalid filename dialog. But there is code "{o}" in this dialog title.

Expects:
This parameter "{0}" should be replaced by string "file" or "directory".

ENV: Mac 10.7.5 English OS
Build: 0.28.0.8326

Snapshots:
Please refer to snapshot for details:
screen shot 2013-07-14 at 10 33 01 pm

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Monday Jul 15, 2013 at 16:27 GMT


High priority. Recent regression and this looks bad

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 15, 2013 at 18:47 GMT


Reviewed. Bumping down to medium priority - we generally reserve high priority for crash/hang/data loss. I agree that we should fix it in this sprint though.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 15, 2013 at 18:58 GMT


Also, when adding a bug to the current sprint that isn't related to a current story (i.e., it was introduced in a previous sprint), please add it to the bug card in Trello. (I went ahead and added this one.) Thanks.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Monday Jul 15, 2013 at 19:45 GMT


@njx I marked this high priority because it was introduced in the last sprint. Should we not mark regressions a high priority? Just trying to understand the triage process :) It totally makes sense that this has no functional impact but the fact that it was a recent injection swayed me to up the priority.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 15, 2013 at 19:49 GMT


Hey - we don't assign priority based on whether it's a regression or not - the priority is about user impact.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Jul 17, 2013 at 16:28 GMT


Assigning to@TomMalbran. Thanks for the easy fix.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Wednesday Jul 17, 2013 at 20:35 GMT


FBNC@julieyuan

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Thursday Jul 18, 2013 at 02:30 GMT


Thanks. I checked in build 0.28.0-8376 and not fixed yet in this build. I will check it in tomorrow's build again.

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Friday Jul 19, 2013 at 02:41 GMT


It is fixed in build 0.28.0.8416. So closed it. Please refer to snapshot for details:
screen shot 2013-07-18 at 7 38 39 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant