[CLOSED] Fix unit tests broken by modal bar animation

[core-ai-bot]

Issue by njx
Friday Aug 16, 2013 at 22:41 GMT
Originally opened as adobe/brackets#4800

---

The modal bar animation added by@larz0 added a bit of asynchronicity to the modal bar: it now isn't removed from the DOM until the close animation completes. This pull request fixes up the unit tests so that they wait for the previous modal bar to close (and forcibly remove it at the end of the test) before continuing.

Also, some unit tests were breaking because the modal bar was never removing itself from the DOM. This was due to a subtle issue: the new modal bar code was using the .hide class, but that class is also defined by Bootstrap to set display: none. That wasn't affecting the modal bar's behavior in Brackets itself, but was affecting it in the test runner, possibly because stylesheets are loaded in a different order. So I just renamed the class to .modal-bar-hide to avoid getting contaminated by the Bootstrap rule.

---

njx included the following code: https://github.com/adobe/brackets/pull/4800/commits

[core-ai-bot]

Comment by njx
Friday Aug 16, 2013 at 22:44 GMT

---

I highly recommend reviewing with ?w=1 :)

[core-ai-bot]

Comment by njx
Friday Aug 16, 2013 at 22:54 GMT

---

@gruehle or@peterflynn--interested in taking this one? Want to get it checked in today since the unit tests are broken.

Note that this does mean that the timing of when modal bars appear/disappear has changed...but I'm inclined not to worry about it too much unless we find actual user-visible issues.

[core-ai-bot]

Comment by njx
Friday Aug 16, 2013 at 22:54 GMT

---

Oops, retagging@peterflynn

[core-ai-bot]

Comment by njx
Friday Aug 16, 2013 at 22:57 GMT

---

For #4797

[core-ai-bot]

Comment by gruehle
Friday Aug 16, 2013 at 23:52 GMT

---

Looks good. Merging.