[CLOSED] Slovak language support

[core-ai-bot]

Issue by erichstark
Wednesday Aug 21, 2013 at 13:37 GMT
Originally opened as adobe/brackets#4856

---

---

erichstark included the following code: https://github.com/adobe/brackets/pull/4856/commits

[core-ai-bot]

Comment by zaggino
Thursday Aug 22, 2013 at 02:57 GMT

---

Translations look good to me.

[core-ai-bot]

Comment by julianasuh
Thursday Aug 22, 2013 at 17:22 GMT

---

We will keep this pull request open until we receive the rest of strings.

[core-ai-bot]

Comment by erichstark
Thursday Aug 22, 2013 at 17:32 GMT

---

Okey. I will working on it.

[core-ai-bot]

Comment by erichstark
Friday Aug 30, 2013 at 13:54 GMT

---

It is done.

[core-ai-bot]

Comment by zaggino
Friday Aug 30, 2013 at 16:09 GMT

---

@erichstark quite a nice work ... but I don't know how the different plurals should be handled in the future ... you must agree the final result will sound a bit strange. Saying that, there's nothing you can do with it here.

[core-ai-bot]

Comment by erichstark
Friday Aug 30, 2013 at 16:33 GMT

---

@zaggino Yes, you are right. But I can't do it more with that problem. I think that base of Slovak translation is okay and some of strings can be fixed in future release to fit better.

[core-ai-bot]

Comment by njx
Friday Aug 30, 2013 at 16:33 GMT

---

Interesting...I know there are a number of languages with varying plurals for different numbers. I wonder if there's some special kind of substitution syntax we could make up to handle this generally, and augment StringUtils.format() to handle it. I can't think of anything simple...it would have to let you enumerate various numbers or number ranges and give an associated plural.

Seems like this problem must have been solved in other localization string table systems...wonder if there's any format we could use as a reference.

[core-ai-bot]

Comment by njx
Friday Aug 30, 2013 at 16:34 GMT

---

(BTW, I'm not saying we have to solve that before merging this :) - if you guys are comfortable with it for now, we can merge it and file a bug to solve that problem later.)

[core-ai-bot]

Comment by zaggino
Friday Aug 30, 2013 at 16:55 GMT

---

@njx I think it's good to merge and it's a good work from@erichstark . I just felt that it was important to mention the plural problem in Slovak language :-)

[core-ai-bot]

Comment by erichstark
Friday Aug 30, 2013 at 17:05 GMT

---

@zaggino Thank you. :)

[core-ai-bot]

Comment by njx
Friday Aug 30, 2013 at 17:14 GMT

---

I filed #5007 for adding something to the string handling to make it possible to specify multiple plurals.

[core-ai-bot]

Comment by jasonsanjose
Friday Sep 06, 2013 at 17:51 GMT

---

@erichstark almost ready to merge. Just a few minor fixes.

[core-ai-bot]

Comment by erichstark
Friday Sep 06, 2013 at 19:01 GMT

---

@jasonsanjose Everything seems be ok.