[CLOSED] Make code hint insertion on tab key configurable

[core-ai-bot]

Issue by iwehrman
Thursday Sep 05, 2013 at 23:23 GMT
Originally opened as adobe/brackets#5084

---

Addresses #4963 by making the behavior of the CodeHintList on tab key events configurable on a global and per-CodeHintProvider basis. The CodeHintManager provider registration API is generalized with an additional optional property, insertHintOnTab, that indicates whether the CodeHintManager should request that the provider of the current session insert the currently selected hint on tab key events, or if instead a tab character should be inserted into the editor. If a provider omits this property, the behavior is determined by the CodeHintManager. The default behavior is to insert a tab character into the editor, as is the case now. The default can be changed globally with the new CodeHintManager.setInsertHintOnTab(bool) method. For an example use of this method, see my awesome new extension: iwehrman/brackets-insert-hint-on-tab.

This was@peterflynn's idea!

---

iwehrman included the following code: https://github.com/adobe/brackets/pull/5084/commits

[core-ai-bot]

Comment by RaymondLim
Friday Sep 06, 2013 at 00:11 GMT

---

Done initial review. just 2 minor nits.

[core-ai-bot]

Comment by iwehrman
Friday Sep 06, 2013 at 00:19 GMT

---

I fixed both of these issues, so this is ready for re-review. Thanks for the quick turnaround!

[core-ai-bot]

Comment by RaymondLim
Friday Sep 06, 2013 at 01:39 GMT

---

@iwehrman Seems like you haven't pushed your commit yet.

[core-ai-bot]

Comment by iwehrman
Friday Sep 06, 2013 at 02:24 GMT

---

Whoops again. Sorry about that. Commits are pushed now.

[core-ai-bot]

Comment by RaymondLim
Friday Sep 06, 2013 at 02:31 GMT

---

Looks good... Merging.