[CLOSED] Add Greek Localization

[core-ai-bot]

Issue by sirodoht
Sunday Sep 29, 2013 at 18:46 GMT
Originally opened as adobe/brackets#5378

---

This is the Greek localization for Brackets. Consider merging.

---

sirodoht included the following code: https://github.com/adobe/brackets/pull/5378/commits

[core-ai-bot]

Comment by MarcelGerber
Monday Oct 28, 2013 at 20:20 GMT

---

@sirodoht You should find someone to do a review of your translation.

[core-ai-bot]

Comment by sirodoht
Monday Oct 28, 2013 at 20:25 GMT

---

Yes, I know, but doesn't he need to be someone trustworthy?

[core-ai-bot]

Comment by MarcelGerber
Monday Oct 28, 2013 at 20:33 GMT

---

We will trust you/him ;) The only thing is that he should have a GitHub account (and can speak greek).

[core-ai-bot]

Comment by couzteau
Friday Nov 08, 2013 at 17:37 GMT

---

@sirodoht Any update on finding a reviewer?

[core-ai-bot]

Comment by sirodoht
Friday Nov 08, 2013 at 17:42 GMT

---

@couzteau Yes, I have found one. But before I want to update my translation a little bit. I haven't checked in a while on any updates on Brackets. When does it need to be ready in order to make it to the next sprint?
Also, do I need more than one reviewers?

[core-ai-bot]

Comment by couzteau
Friday Nov 08, 2013 at 17:54 GMT

---

@sirodoht thanks for the update. Our next sprint end Nov 15.

[core-ai-bot]

Comment by couzteau
Monday Nov 11, 2013 at 18:22 GMT

---

@sirodoht if you can land your changes by Thursday the timing would be better to get the changes into sprint 34.

[core-ai-bot]

Comment by sirodoht
Monday Nov 11, 2013 at 18:34 GMT

---

@couzteau I see. I will try to do this. Otherwise when is the next sprint release date?

[core-ai-bot]

Comment by MarcelGerber
Monday Nov 11, 2013 at 19:01 GMT

---

The milestone is set to December 8, so I expect the string freeze to be around December 3 or 4.
If you can't complete the work fast enough to get it into this sprint, you should land it in the beginning of December.

[core-ai-bot]

Comment by couzteau
Monday Nov 11, 2013 at 19:11 GMT

---

That date is off, sprint 34 pencils down date is this thursday Nov 14.

[core-ai-bot]

Comment by sirodoht
Monday Nov 11, 2013 at 19:15 GMT

---

@couzteau@SAPlayer and I were referring to sprint 35. I understand your confusion since 34 is the next sprint, but I meant 35.

[core-ai-bot]

Comment by MarcelGerber
Monday Nov 11, 2013 at 19:19 GMT

---

@sirodoht My comment was about Sprint 35 ;)

[core-ai-bot]

Comment by couzteau
Tuesday Nov 19, 2013 at 21:53 GMT

---

@sirodoht Hey, any progress on the greek translation?

[core-ai-bot]

Comment by sirodoht
Wednesday Nov 20, 2013 at 17:25 GMT

---

@couzteau I am kind of busy these days. I hope in the next 3-4 days to have updated the translation and will be reviewed as soon as I am done.

[core-ai-bot]

Comment by sirodoht
Saturday Nov 23, 2013 at 12:57 GMT

---

Update finished. Awaiting review.
I merged master changes and rebased. If this is not an approved technique I guess I could close this and open a new pull request.

[core-ai-bot]

Comment by telis93
Saturday Nov 23, 2013 at 20:11 GMT

---

@couzteau I reviewed this translation and contributed with some minor fixes. It is a realy good work!

[core-ai-bot]

Comment by couzteau
Thursday Jan 02, 2014 at 23:22 GMT

---

One more detail: In brackets/src/nls/root/strings.js there should be an entry
"LOCALE_EL" : "Greek",

[core-ai-bot]

Comment by couzteau
Thursday Jan 02, 2014 at 23:24 GMT

---

@telis93@sirodoht Sorry for the late reply. I was on vacation for the last 3 weeks.

[core-ai-bot]

Comment by sirodoht
Friday Jan 03, 2014 at 11:26 GMT

---

@couzteau Done. Should I also merge master changes?

[core-ai-bot]

Comment by couzteau
Friday Jan 03, 2014 at 19:54 GMT

---

This is looking good. Merging Thanks@sirodoht@telis93