[CLOSED] Fix URL hints not showing

[core-ai-bot]

Issue by WebsiteDeveloper
Friday Oct 04, 2013 at 13:57 GMT
Originally opened as adobe/brackets#5422

---

#4949

@redmunds because the issue is assigned to you.

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/5422/commits

[core-ai-bot]

Comment by redmunds
Thursday Oct 10, 2013 at 16:31 GMT

---

This looks good. Since that if statement was removed, this code:

        var tagInfo,
            query,
            tokenType;

        this.editor = editor;

        tagInfo = HTMLUtils.getTagInfo(editor, editor.getCursorPos());
        query = null;
        tokenType = tagInfo.position.tokenType;

Should be cleaned up to:

        var tagInfo   = HTMLUtils.getTagInfo(editor, editor.getCursorPos()),
            query     = null,
            tokenType = tagInfo.position.tokenType;

        this.editor = editor;

[core-ai-bot]

Comment by redmunds
Tuesday Oct 15, 2013 at 22:19 GMT

---

@WebsiteDeveloper Reminder: just a small code cleanup change remaining.

[core-ai-bot]

Comment by redmunds
Thursday Oct 17, 2013 at 02:52 GMT

---

Merging. No need to hold this up for a little code cleanup.

[core-ai-bot]

Comment by WebsiteDeveloper
Friday Oct 18, 2013 at 11:17 GMT

---

@redmunds sry i was away a few days, but i'm glad it is finally merged.