Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Change not.toBeNull() to toBeTruthy() in unit tests #5044

Open
core-ai-bot opened this issue Aug 30, 2021 · 2 comments
Open

[CLOSED] Change not.toBeNull() to toBeTruthy() in unit tests #5044

core-ai-bot opened this issue Aug 30, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by gmeluski
Friday Oct 11, 2013 at 21:25 GMT
Originally opened as adobe/brackets#5492

A fix for adobe/brackets#5479

Please let me know if I missed anything, this is my first one!

gmeluski included the following code: https://github.com/adobe/brackets/pull/5492/commits
@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Oct 11, 2013 at 22:17 GMT

Edited the subject line of the pull request to make it more clear what it was about (pull requests should have semantic titles rather than just the name of the bug they're addressing). Thanks.

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Friday Oct 18, 2013 at 12:48 GMT

Looks good! Thanks for doing this,@gmeluski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot