Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Make JS code hint test runs more consistent #5397

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] Make JS code hint test runs more consistent #5397

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by dangoor
Friday Nov 08, 2013 at 15:21 GMT
Originally opened as adobe/brackets#5904


I changed the resetting behavior for code hint tests to eliminate uncertainty that is causing some test failures. This change also adds some scaffolding that makes it easier to track down JS code hint issues.

Hopefully fixes #5754. This definitely fixes #5811.


dangoor included the following code: https://github.com/adobe/brackets/pull/5904/commits

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Nov 08, 2013 at 17:32 GMT


Assigned to me

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Nov 08, 2013 at 19:22 GMT


Initial review complete

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Monday Nov 11, 2013 at 20:45 GMT


@jasonsanjose I've just pushed a commit that addresses the comments. The only one I didn't directly address is the if (config.debug) one. Take a look at my response to your comment and let me know what you think. Thanks!

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Monday Nov 11, 2013 at 20:50 GMT


Err, just looked at my todo list and realized that I have another change to make (setConfig in tern-worker taking the whole config rather than merging it)

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Monday Nov 11, 2013 at 20:58 GMT


OK, updated setConfig in tern-worker.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Monday Nov 11, 2013 at 21:27 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant