Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] add 'Korean (ko)' Localization #5714

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] add 'Korean (ko)' Localization #5714

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by heisice
Thursday Dec 19, 2013 at 10:02 GMT
Originally opened as adobe/brackets#6272


i added Korean Language Localization files. please merge, thanks.


heisice included the following code: https://github.com/adobe/brackets/pull/6272/commits

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Thursday Dec 19, 2013 at 18:37 GMT


Thanks@heisice. If you know any other Korean speakers that can review this, please go ahead and tag them here. Also, please sign the contributor license agreement http://dev.brackets.io/brackets-contributor-license-agreement.html so that we can merge this pull request after review.

@core-ai-bot
Copy link
Member Author

Comment by heisice
Friday Dec 20, 2013 at 02:47 GMT


sign contributor license agreement was done. thanks.

@core-ai-bot
Copy link
Member Author

Comment by heisice
Friday Jan 03, 2014 at 09:01 GMT


translation updated. thank you for review,@everyevery.
@jasonsanjose, can you merge this?

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Jan 03, 2014 at 17:19 GMT


Thanks@heisice. A few more things to do:

  • Add "LOCALE_KO" : "Korean" to nls/root/strings.js as well as nls/ko/strings.js. Other languages will be updated separately. This is used to display the language name in Debug > Switch Language.
  • Fix indentation to use 4 spaces instead of tabs in nls/ko/strings.js

I can merge this PR as soon as this is done.

@core-ai-bot
Copy link
Member Author

Comment by heisice
Saturday Jan 04, 2014 at 02:18 GMT


ok. all done.
please merge,@jasonsanjose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant