Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Win XP: Disabled menu items are not grayed out #5864

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] Win XP: Disabled menu items are not grayed out #5864

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Friday Jan 10, 2014 at 00:05 GMT
Originally opened as adobe/brackets#6449


  1. Launch on Windows XP with the shell from Dark Shell Implementation using Aero Glass adobe/brackets-shell#408
  2. Open the Navigate menu
  3. Click 'Next Match'

Result:
2 - no menu items are grayed out
3 - nothing happens; menu remains open

Expected:
2 - Previous Match, Next Match, and New Rule should all be grayed out (typically Go to First Error too)
3 - this is correct for disabled menu items, it's just confusing because the menu items aren't visibly disabled

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Jan 10, 2014 at 00:07 GMT


@JeffryBooher This one we probably should fix this sprint, though (unless it repros before your changes, which is possible -- I haven't tested yet)

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Jan 10, 2014 at 00:49 GMT


ah... yes, I think I know why because it needs MF_GRAYED|MF_DISABLED. This should have reproduced in older versions of the shell as well. At least I remember either writing and issue for it or fixing it.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Jan 10, 2014 at 00:52 GMT


That may have been something that I discovered while working on Reflow... I'll whip up a fix for it.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Jan 10, 2014 at 01:00 GMT


Removed [AERO DARK SHELL] from title since this is legacy and FBNC@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Jan 10, 2014 at 01:19 GMT


@jeffkenton Yep, looks like this was a problem on XP not only with earlier dark shell builds, but also with even the generic brackets-shell before that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant