[CLOSED] Fix convertPreferences to accept non-module clientIDs

[core-ai-bot]

Issue by MarcelGerber
Friday Apr 04, 2014 at 21:35 GMT
Originally opened as adobe/brackets#7415

---

Quick story:
I wanted to update the Theseus preferences system (adobe-research/theseus#55), but after a while I saw that convertPreferences will only work if the passed clientID is module. But in the case of Theseus, strings are used as clientID (like com.adobe.theseus).
This fixes this issue.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/7415/commits

[core-ai-bot]

Comment by MarcelGerber
Saturday Apr 05, 2014 at 09:39 GMT

---

Would be cool if this gets into Sprint 38.
To see the code that's currently failing (but working with this fix), you can take a look at https://github.com/SAPlayer/theseus/commit/8de661cf2c08387e8f0b3ed659236daf310e7ff8.

[core-ai-bot]

Comment by bchintx
Monday Apr 07, 2014 at 21:50 GMT

---

Thanks for fixing this,@SAPlayer ! I was just about to investigate doing the same thing for a different extension that was using a different client ID as well.

Finished code review. Merging...