{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":217135902,"defaultBranch":"master","name":"arkouda","ownerLogin":"bradcray","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-10-23T19:21:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7536222?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1699054374.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"41ade53b2952a65d120b811e36926fc017159277","ref":"refs/heads/fix-cxx-conditional","pushedAt":"2023-11-03T23:32:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bradcray","name":"Brad Chamberlain","path":"/bradcray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7536222?s=80&v=4"},"commit":{"message":"Fix a Makefile conditional to test for empty string instead of 'none'\n\nI was hitting an issue where, due to not having CHPL_HOME set,\nCHPL_CXX was being set to the empty string and the 'make\ncompile-arrow-cpp' step would fail as follows due to not having a C++\ncompiler specified (I'm still not sure where the '-' on the '-O3'\noption went...):\n\n```\nO3 -std=c++17 -c /Users/bradc/arkouda//src/ArrowFunctions.cpp -o /Users/bradc/arkouda//src/ArrowFunctions.o -I/Users/bradc/arkouda//dep/zeromq-install/include -L/Users/bradc/arkouda//dep/zeromq-install/lib -I/Users/bradc/arkouda//dep/hdf5-install/include -L/Users/bradc/arkouda//dep/hdf5-install/lib -I/Users/bradc/arkouda//dep/arrow-install/include -L/Users/bradc/arkouda//dep/arrow-install/lib -I/Users/bradc/arkouda//dep/arrow-install/include -L/Users/bradc/arkouda//dep/arrow-install/lib -I/opt/homebrew/opt/libiconv/include -L/opt/homebrew/opt/libiconv/lib -fsanitize=\nmake: O3: No such file or directory\n```\n\nThe conditional that was designed to guard against this is the following:\n\n```make\nifeq ($(CHPL_CXX),none)\nCHPL_CXX=$(CXX)\nendif\n```\n\nbut this didn't fire because CHPL_CXX wasn't unset, it was simply set\nto the empty string.  Here, I've changed the logic to:\n\n```make\nifeq ($(CHPL_CXX),)\nCHPL_CXX=$(CXX)\nendif\n```\n\nto test for the empty string, which causes CXX to be set to g++ as\nintended.\n\n---\nSigned-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>","shortMessageHtmlLink":"Fix a Makefile conditional to test for empty string instead of 'none'"}},{"before":"f02239986159980355746e7fd435b846562083d5","after":"0a1cd0c809a3d6ef8b9600be5a90703344ced537","ref":"refs/heads/patch-1","pushedAt":"2023-09-15T03:12:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradcray","name":"Brad Chamberlain","path":"/bradcray","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7536222?s=80&v=4"},"commit":{"message":"Convert check for re2 in the compiler from a .compile() method to new regex()\n\n    In Chapel 1.30, regex.compile() was deprecated in favor of new regex(),\r\n    however the program that verifies that regex is enabled in Arkouda\r\n    wasn't updated, so was still relying on this routine.  We removed the\r\n    routine tonight and broke our smoke tests, not realizing this.  Here,\r\n    I've updated the test to use 'new regex()' instead.","shortMessageHtmlLink":"Convert check for re2 in the compiler from a .compile() method to new…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0wM1QyMzozMjo1NC4wMDAwMDBazwAAAAOnH7E6","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0wM1QyMzozMjo1NC4wMDAwMDBazwAAAAOnH7E6","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOS0xNVQwMzoxMjo0Ny4wMDAwMDBazwAAAAOBGlAQ"}},"title":"Activity · bradcray/arkouda"}