Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] bug of connect.base.py's require function #413

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Routhleck
Copy link
Collaborator

Description

The bug is on the line 428 of connect/base.py

elif COO in structures and not _has_coo_imp:

For the connectors of ScaleFreeBA, ScaleFreeBADual and PowerLaw, build_mat function has already implemented and there is no build_coo function, if we want to require bp.connect.COO, the judgment here is going to be correct and it's going to go down. So the logic here is wrong, just remove not is ok.

@chaoming0625 chaoming0625 merged commit 14dc245 into brainpy:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants