Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to jison 0.4.15 #102

Closed
bramp opened this issue May 17, 2015 · 2 comments
Closed

Upgrade to jison 0.4.15 #102

bramp opened this issue May 17, 2015 · 2 comments

Comments

@bramp
Copy link
Owner

bramp commented May 17, 2015

Upgrade to the latest jison by editing the value in the package.json. However the latest jison has made atleast two changes.

  1. Renamed grammar to parser
  2. Defensively copies the passed in yy object. This copy turns it from a "Diagram" to a plain "Object", which doesn't have the "drawSVG" method on it.
@bramp
Copy link
Owner Author

bramp commented May 17, 2015

Fixed in 15b7916, and noted that other projects had a similar issue: zaach/jison#243

@bramp bramp closed this as completed May 17, 2015
@bramp
Copy link
Owner Author

bramp commented May 17, 2015

oh, but there is one lasting issue, that jison does not produce strict javascript output anymore. I reported the issue here zaach/jison#285 This should not be a problem as our minifier stripes out the non-strict portions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bramp