Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return(deliver_stale) #4

Open
selwynpolit opened this issue Apr 26, 2017 · 4 comments
Open

return(deliver_stale) #4

selwynpolit opened this issue Apr 26, 2017 · 4 comments

Comments

@selwynpolit
Copy link

The plugin stops its cool syntax hilighting if I try return(deliver_stale) This is used in fastly's VCL 2.x fork. See https://docs.fastly.com/guides/performance-tuning/serving-stale-content

/* deliver stale if the object is available */
if (stale.exists) {
  return(deliver_stale);
}
@lukevers
Copy link

lukevers commented Aug 4, 2017

Found this ticket through here. I, too, have noticed that if using deliver_stale the syntax highlighting in GitHub stops. It's pretty annoying.

@lukevers
Copy link

lukevers commented Aug 4, 2017

My guess is we'd just have to add deliver_stale in here.

- <string>(deliver|error|fetch|hash|hit_for_pass|lookup|ok|pass|pipe|restart|synth|retry|abandon|fail|purge)</string>
+ <string>(deliver|deliver_stale|error|fetch|hash|hit_for_pass|lookup|ok|pass|pipe|restart|synth|retry|abandon|fail|purge)</string>

@lukevers
Copy link

lukevers commented Aug 4, 2017

Just opened a PR and tested it out (see #5). deliver_stale needed to be before deliver, but it's working now.

@lukevers
Copy link

@brandonwamboldt Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants