Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported t.myvisualiq.net rule #866

Closed
fmarier opened this issue May 27, 2022 · 0 comments
Closed

Remove unsupported t.myvisualiq.net rule #866

fmarier opened this issue May 27, 2022 · 0 comments
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented May 27, 2022

The t.myvisualiq.net rule introduced in #716 cannot be expressed correctly until brave/brave-browser#22429 is implemented.

The example URL:

  • https://t.myvisualiq.net/click_pixel?et=c&ago=212&ao=126&aca=71120122347799678&si=-2&ci=-2&pi=-2&ad=58120001282129221&sv1=43121240841212382&advt=-2&chnl=-2&vndr=335&sz=6583&u=6e790e6681711263e3af6fd3c9e2c788&red=https://www.bestbuy.com/site/electronics/top-deals/pcmcat1523299784494.c?id=pcmcat1563223712494&ref=213&loc=1&gclsrc=3p.ds&ds_rl=3223423&ref=212&loc=DWA

currently gets debounced to:

  • https://www.bestbuy.com/site/electronics/top-deals/pcmcat1523299784494.c?id=pcmcat1563223712494

instead of the full URL:

  • https://www.bestbuy.com/site/electronics/top-deals/pcmcat1523299784494.c?id=pcmcat1563223712494&ref=213&loc=1&gclsrc=3p.ds&ds_rl=3223423&ref=212&loc=DWA

because the extra query string parameter are swallowed up by the debouncer's parsing.

We see in the original URL that the red parameter includes a ? (the second one in that URL) which is a sign that it's not URL-encoded and so these URLs are not using the HTML5 form encoding for their query strings.

@fmarier fmarier changed the title Remove unsupported t.myvisualiq.net rule Remove unsupported t.myvisualiq.net rule May 27, 2022
@fmarier fmarier self-assigned this May 27, 2022
@ryanbr ryanbr closed this as completed in a84cfe7 May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant