Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Update favicons for internal pages #10071

Closed
3 tasks done
rebron opened this issue Jun 3, 2020 · 3 comments · Fixed by brave/brave-core#5732
Closed
3 tasks done

[Desktop] Update favicons for internal pages #10071

rebron opened this issue Jun 3, 2020 · 3 comments · Fixed by brave/brave-core#5732

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 3, 2020

Description

Follow-up to: #8492.

Update favicons for:

  • brave://settings
  • brave://history
  • brave://downloads

Steps to Reproduce

  1. Go to the internal pages above.
  2. Notice they're using chromium provided icons
  3. Expected result is that icons are Brave provided favicons

Actual result:

Screen Shot 2020-06-03 at 11 50 26 AM

Designs (expected result):

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@rebron rebron added feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. misc/icons OS/Desktop labels Jun 3, 2020
@rebron
Copy link
Collaborator Author

rebron commented Jun 3, 2020

cc: @simonhong

@karenkliu
Copy link

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 16, 2020

Verification passed on

Brave | 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1903 (Build 18362.30)

  • Verified the STR from the description
  • Installed 1.10.x and upgraded to 1.11.x and verified that settings, download and history icons are replaced with brave branded favicons
    image

Verified passed with

Brave | 1.11.78 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

1.10.x favicons for Settings, Downloads, Bookmarks, History:
Screen Shot 2020-06-26 at 3 41 41 PM
Screen Shot 2020-06-26 at 3 41 54 PM

1.11.x favicons for Settings, Downloads, Bookmarks, History:
Screen Shot 2020-06-26 at 3 42 43 PM
Screen Shot 2020-06-26 at 3 42 30 PM


Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

1.11.x favicons for Settings, Bookmarks, Downloads, History (dark)
Screen Shot 2020-07-01 at 12 16 35 PM

1.11.x favicons for Settings, Bookmarks, Downloads, History (light)
Screen Shot 2020-07-01 at 12 16 45 PM

@rebron rebron changed the title Update favicons for internal pages [Desktop] Update favicons for internal pages Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants