Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix USD balance in rewards panel #10072

Closed
deeppandya opened this issue Jun 3, 2020 · 1 comment · Fixed by brave/brave-core#5730
Closed

[Android] Fix USD balance in rewards panel #10072

deeppandya opened this issue Jun 3, 2020 · 1 comment · Fixed by brave/brave-core#5730

Comments

@deeppandya
Copy link
Contributor

Description

USD balance always shows 0.0

Steps to reproduce

  1. add fund to the account
  2. notice that it shows 0.0 to usd balance

Actual result

USD balance is always 0.0 in rewards panel

Expected result

USD balance should show the correct value.

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@btlechowski
Copy link

btlechowski commented Jun 17, 2020

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

From UGP grant:
Screenshot_20200617-045820_Brave

From Verified wallet + UGP grant
Screenshot_20200617-050825_Brave


Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernaram 1.10.92.apk

  • Verified the USD value is displayed correctly in Rewards panel when wallet is funded via UGP grants
    UGP grants
    Screenshot_2020-06-17-15-49-24

  • Verified that USD value is displayed correctly in Rewards panel when the wallet is funded via UGP grants+KYC'd uphold account
    Screenshot_2020-06-17-16-04-15

  • Verified that the USD valu is displayed as expected in other areas like Rewards summary, AC panel, Monthly tip panel, One-time tips panel and Tipping banner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants