P3A - Incorrect response values for Auto-contribute

[GeetaSarvadnya]

Description

P3A - Incorrect response values for Auto-contribute

(Brave.Rewards.AutoContributionsState.2)

0. No wallet created
1. Rewards Disabled
2. Wallet created, Auto-Contribute off
3. Auto-contribute enabled, no contribution so far
4. Auto-contribute enabled, one successful contribution so far
5. Auto-contribute enabled, more than one successful contribution so far

Steps to Reproduce

  1. Clean profile 1.10.x launch brave using `brave.exe --rewards=staging=true,reconcile-interval=3`
  2. Enable rewards
  3. Claim UGP grant
  4. Open local-state file and look for "Brave.Rewards.AutoContributionsState.2"
  5. `Brave.Rewards.AutoContributionsState.2` is set to `3`  (`Auto-contribute enabled, no contribution so far`) as expected
  6. Wait for 1st auto contribution
  7. After AC, `Brave.Rewards.AutoContributionsState.2` is set to `3` (`Auto-contribute enabled, no contribution so far`) instead of `4` (`Auto-contribute enabled, one successful contribution so far`)
  8. Trigger 2nd auto contribution
  9. After AC, `Brave.Rewards.AutoContributionsState.2` is set to `3` (`Auto-contribute enabled, no contribution so far`) instead of `5` (`Auto-contribute enabled, more than one successful contribution so far`)

Note: The issue started appearing after 1.5.x

Actual result:

P3A - Incorrect response values for Auto-contribute

Expected result:

correct response values should be displayed for Auto-contribute in Brave Rewards

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.10.84 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes in 1.9.x, 1.8.x, 1.7.x. Not in 1.5.123
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?NA
• Does the issue resolve itself when disabling Brave Rewards?NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mattmcalister @bsclifton @rebron @iefremov

[rebron]

cc: @NejcZdovc

[GeetaSarvadnya]

This issue is arising in Android also, Verified in the nightly build 1.20.74

[stephendonner]

Verified PASSED using

Brave	1.25.19 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. Clean profile 1.10.x launch using brave.exe --rewards=staging=true,reconcile-interval=3
2. Enabled rewards
3. Claimed UGP grant
4. Opened brave://local-state and looked for "Brave.Rewards.AutoContributionsState.2"
5. Confirmed Brave.Rewards.AutoContributionsState.2 is set to 3 (Auto-contribute enabled, no contribution so far) as expected
6. Waited for 1st auto contribution
7. After AC, verified Brave.Rewards.AutoContributionsState.2 was correctly now set to 4 (Auto-contribute enabled, one successful contribution so far)
8. Triggered 2nd auto contribution
9. After AC, confirmed Brave.Rewards.AutoContributionsState.2 was set to 5 (Auto-contribute enabled, more than one successful contribution so far)

example	example	example	example	example	example

---

Verification passed on

Brave | 1.25.57 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

• Verified the STR from the description

Rewards enabled but no AC	After 1st AC	After 2nd AC

---

Verification passed on

Brave	1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

• Verified steps from issue description

---

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

• Verified steps from issue description