Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Incognito tab is shown for non en-US languages #10105

Closed
srirambv opened this issue Jun 5, 2020 · 4 comments
Closed

[Android] Incognito tab is shown for non en-US languages #10105

srirambv opened this issue Jun 5, 2020 · 4 comments
Assignees
@samartnik
Labels
feature/settings l10n needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 5, 2020

Description

Incognito tab is shown for non en-US languages

Steps to reproduce

  1. Set device language to non en-US
  2. Open settings
  3. Search engine shows Incognito instead of Private

Actual result

image

Expected result

image

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet):Phone
  • Android version: 10

Brave version

1.9.79

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv added QA/Yes release-notes/include feature/settings OS/Android Fixes related to Android browser functionality labels Jun 5, 2020
@bsclifton bsclifton added the l10n label Jun 8, 2020
@bsclifton bsclifton added OS/Desktop needs-text-change This change requires some careful wording. priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 13, 2021
@rebron rebron removed the OS/Desktop label Apr 13, 2021
@srirambv srirambv mentioned this issue May 19, 2021
Closed
@srirambv
Copy link
Contributor Author

+1 from @fmarier via #15951

@samartnik
Copy link
Contributor

Problem was with older translation that we had in Transifex. Old translations are removed and we are just waiting for the new translations. Thank you @mkarolin for the help!

@samartnik
Copy link
Contributor

New translations are already applied

@samartnik samartnik added this to the 1.31.x - Nightly milestone Sep 3, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Oct 5, 2021

Verification passed on the following devices running 1.31.67 x64 beta build

  • Verified setting locale to en-UK shows as Private tab
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)

@kjozwiak kjozwiak mentioned this issue Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/settings l10n needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release
Development

No branches or pull requests
4 participants
@bsclifton @rebron @srirambv @samartnik