Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Make Rewards message close button more visible #10378

Closed
eljuno opened this issue Jun 19, 2020 · 1 comment · Fixed by brave/brave-core#6033
Closed

[Desktop] Make Rewards message close button more visible #10378

eljuno opened this issue Jun 19, 2020 · 1 comment · Fixed by brave/brave-core#6033

Comments

@eljuno
Copy link

eljuno commented Jun 19, 2020

Description

Originally reported here https://community.brave.com/t/brave-rewards-wallet-not-connecting-anymore/135056 and here https://community.brave.com/t/brave-rewards-says-my-wallet-is-disconnected-but-also-says-that-its-connected/136328?u=eljuno but have seen similar feedbacks before.

Currently, X close button for Rewards messages is not clearly visible so there's a chance user didn't notice it.

Steps to Reproduce

Waiting for the message to appear by itself? e.g. backup message or connection error message (see screenshot)

Actual result:

462c492be7a585562f696933c782a203d12872f6

Expected result:

More visible

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? NDA
  • Can you reproduce this issue with the dev channel? NDA
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

cc @rebron @srirambv

@srirambv srirambv added the design A design change, especially one which needs input from the design team label Jun 24, 2020
@NejcZdovc NejcZdovc removed the design A design change, especially one which needs input from the design team label Jun 30, 2020
@NejcZdovc NejcZdovc added this to the 1.12.x - Beta milestone Jul 8, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 22, 2020

Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Close (x) button in 1.11.x Close (x) button in 1.12.x
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment