[Desktop] - contributed amount has gone over the wallet balance

[GeetaSarvadnya]

Description

The contributed amount has gone over the wallet balance

Steps to Reproduce

1. Clean profile
2. Launch brave using brave.exe --enable-logging --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=3,short-retries=true
3. Enable rewards
4. Claim UGP grants of 30 BAT
5. Add DDG and https://www.3zsistemi.si/ to AC table
6. Setup recurring tips of 1 BAT to DDG and https://www.3zsistemi.si/
7. Send a one-time tips of 1 BAT to DDG and https://www.3zsistemi.si/
8. Wait for 1st AC to happen
9. After AC, 20 BAT is contributed for Auto contribution and 2 BAT is contributed of recurring tips and 2 BAT is sent for one-time tips
10. Wallet balance is 7 BAT instead of 6 BAT
11. Open DB and check unblinded_tokens table, recurring tip for DDG is not being contributed as redeem_id is not present in unblinded_tokens table
12. Add https://www.3zsistemi.si/ table and trigger 2nd AC
13. After AC , the wallet balance becomes 0.0 BAT as expected. But the total contributed amount displayed in summary is 32 BAT - Not sure why 2 BAT extra got contributed when wallet balance is only 30 BAT.

Note: Please let me know if you need DB file or profile for further investigation I can share the profile in DM

Actual result:

The contributed amount has gone over the wallet balance

Expected result:

the contributed amount shouldn't go over the wallet balance

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Windows 10 OS Version 1903 (Build 18362.900)

Version/Channel Information:

• Can you reproduce this issue with the current release? Not in 1.10.x
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

[NejcZdovc]

@GeetaSarvadnya is this one specific to 1.11 or can you reproduce it on 1.10 as well?

[GeetaSarvadnya]

@NejcZdovc Yup, it's happening only in 1.11.x. Not in 1.10.x

[LaurenWags]

@NejcZdovc I looked at @GeetaSarvadnya DB and her recurring tips for ddg (1 BAT each, 2 BAT total) were not in the unblinded_tokens table of her DB, but they were listed in contribution_info. I'll try to reproduce this also.

[LaurenWags]

Not able to reproduce on macOS using

Brave | 1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

Step 10: wallet summary displays as expected:

Step 11 here's my contribution_info and unblinded_tokens tables:

Step 13: wallet summary displays as expected (note, 24 BAT for AC not 26 like @GeetaSarvadnya )

Here are my contribution_info and unblinded_tokens tables after second contribution:

[NejcZdovc]

@GeetaSarvadnya so this is 100% reproducible for you?

[GeetaSarvadnya]

@NejcZdovc Yes, I tried 2times both times issue was reproduced.

[zenparsing]

So far I've not been able to reproduce on master (macOS).

[LaurenWags]

@GeetaSarvadnya could you try on latest Nightly and see if this still reproduces for you?

[kjozwiak]

Moving this out as it's too late for 1.11.x as we're slated to release tomorrow. We'll need to get either @NejcZdovc or @zenparsing to reproduce this or it will be difficult to fix. Maybe we can fix this for 1.12.x 👍

[NejcZdovc]

@GeetaSarvadnya is this still a problem on 1.12/1.13?

[GeetaSarvadnya]

Verified the issue against the build 1.12.99 two times. The issue is not reproducible in 1.12.x anymore, total contributed amount displayed in summary is 30 BAT which equals to wallet balance 30 BAT

1st AC:

2nd AC:

---

2nd Attempt

1 AC:

2nd AC: