Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Modify Look & feel section in brave://settings/shields #10502

Closed
simonhong opened this issue Jun 29, 2020 · 1 comment · Fixed by brave/brave-core#5964
Closed

[Desktop] Modify Look & feel section in brave://settings/shields #10502

simonhong opened this issue Jun 29, 2020 · 1 comment · Fixed by brave/brave-core#5964
Assignees
@simonhong
Labels
feature/settings feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@simonhong
Copy link
Member

simonhong commented Jun 29, 2020 •
edited
Loading

This issue was the part of #8838 but moved to this issue
because this Look & feel section customization is not directly related with moving brave://adblock page and easily fixed.

  • Look & feel section is moved to the top to include choosing Shields default view
  • Show the number of blocked items on the Shields icon is moved above choosing Shields default view

shields
@simonhong simonhong added feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. feature/settings OS/Desktop labels Jun 29, 2020
@simonhong simonhong added this to the 1.12.x - Nightly milestone Jun 29, 2020
@simonhong simonhong self-assigned this Jun 29, 2020
@rebron rebron mentioned this issue Jun 29, 2020
Closed
3 tasks
@simonhong simonhong mentioned this issue Jun 29, 2020
Merged
32 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 22, 2020 •
edited by LaurenWags
Loading

Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)
  • Verified the description mentioned in the issue
  • Verified that Look & Feel Show the number of blocked items on the Shields icon toggle is moved up in the Shield section
  • Verified that toggle Show the number of blocked items on the Shields icon works as expected
1.11.x 1.12.x
image image
  • Verified that changes are applied in Guest window also, and toggle Show the number of blocked items on the Shields icon works as expected
1.11.x Guest window 1.12.x Guest Window
image image

Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

  • Verified the description mentioned in the issue

  • Verified that Look & Feel Show the number of blocked items on the Shields icon toggle is moved up in the Shield section

  • Verified that toggle Show the number of blocked items on the Shields icon works as expected
    image

  • Verified that changes are applied in Guest window also, and toggle Show the number of blocked items on the Shields icon works as expected
    image

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified the description mentioned in the issue
  • Verified that Look & Feel Show the number of blocked items on the Shields icon toggle is moved up in the Shield section
  • Verified that toggle Show the number of blocked items on the Shields icon works as expected
1.11.x 1.12.x
1 11 104 normal window 1 12 108 normal window
  • Verified that changes are applied in Guest window also, and toggle Show the number of blocked items on the Shields icon works as expected
1.11.x Guest window 1.12.x Guest Window
1 11 104 guest window 1 12 108 guest window

@rebron rebron changed the title [Desktop] Modify Look & feel section in Shields [Desktop] Modify Look & feel section in brave://settings/shields Aug 10, 2020
@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/settings feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Move Look & feel section to Shields prefs page brave/brave-core
5 participants
@bsclifton @simonhong @LaurenWags @btlechowski @GeetaSarvadnya