Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Expired ad conversion is not removed from database #10590

Closed
btlechowski opened this issue Jul 7, 2020 · 2 comments
Closed

[Desktop] Expired ad conversion is not removed from database #10590

btlechowski opened this issue Jul 7, 2020 · 2 comments

Comments

@btlechowski
Copy link

btlechowski commented Jul 7, 2020

Follow up to #10240

Steps to Reproduce

  1. Run Brave that points to ads staging server
  2. Download catalog 10240 expire.txt
  3. In the catalog change endAt to now()+4hours. the conversion's expire date will be endAt+24h
  4. Load the ad catalog
  5. Open brave.com and trigger the ad
  6. Close the browser
  7. Make the conversion expire
  8. Run Brave
  9. Open https://www.interia.pl/ to trigger conversion
  10. Check if the entry in the database(Default/ads_service/bundfle_state sqlite ad_conversions) was deleted

Important: The conversion is not triggered, which is good

Actual result:

The entry in the database(Default/ads_service/bundfle_state sqlite ad_conversions) was not deleted:
image

Expected result:

The entry is deleted

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave	1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	macOS Version 10.14.6 (Build 18G3020)

@tmancey
Copy link
Contributor

tmancey commented Jul 7, 2020

@LaurenWags @btlechowski Discussed with @btlechowski as we only remove expired ad conversions once the catalog updates with a new catalog (i.e. the catalog id changes). This is not an issue as expired ad conversions are ignored when checking for new conversions. Thanks

@tmancey tmancey self-assigned this Jul 9, 2020
@tmancey tmancey closed this as completed Aug 5, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants