[Desktop] monthly payment isn't always displayed on brave://rewards correctly - follow up to 10438

[LaurenWags]

Description

Follow up to #10438

Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x

Steps to Reproduce

Scenario 1 from #10438:

1. Clean profile 1.10.97 (needs to be prior to 1.11.x since there were changes to API and prefs in 1.11.x)
2. Enable rewards
3. Change AC settings values except for monthly payment (keep the monthly payment as it is which 20 BAT) - Note, it does not matter if you have brave://rewards page open or closed, result on 1.11.x is the same
4. Upgrade profile to 1.11.x (PR build)
5. Open brave://rewards if necessary, Look for AC Monthly Payment value
   --> blank in AC table, you can view the drop down to see values (no option is checked though)
   --> if you open AC settings, Monthly Payment box is blank/narrow, but you can click on it to view other options (no option is checked though)
   --> Page refresh fixes this

Scenario 2 from #10438:

1. Clean profile 1.10.97
2. Enable rewards
3. Change AC Monthly Budget to some other value (like 100 BAT) - Note, it does not matter if you have brave://rewards page open or closed, result on 1.11.x is the same
4. Upgrade profile to 1.11.x (PR build)
5. Open brave://rewards if necessary, Look for AC Monthly Payment value
   --> blank in AC table, you can view the drop down to see values (no option is checked though)
   --> if you open AC settings, Monthly Payment box is blank/narrow, but you can click on it to view other options (no option is checked though)
   --> Page refresh fixes this

(so basically same as scenario 1 results)

Actual result:

Expected result:

AC monthly budget should be retained without page refresh

Reproduces how often:

Always

Brave version (brave://version info)

was using https://bravesoftware.slack.com/archives/CMH8DU4TF/p1594303165277600 to test (1.11.x PR build for brave/brave-core#6050 due to code changes w/ 1.12.x and 1.13.x that made testing difficult on Nightly)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron @zenparsing

[GeetaSarvadnya]

Verification passed on

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

• Verified the STR from the description

Scenario 1: - Before upgrade in 1.11.x

AC 1.11.x	AC advanced settings 1.11.x	AC advanced settings 1.11.x

After upgrade to 1.12.x

AC 1.12.x	AC advanced settings 1.12.x	AC advanced settings 1.12.x

Scenario 2: - Before upgrade in 1.11.x

AC 1.11.x	AC advanced settings 1.11.x	AC advanced settings 1.11.x

After upgrade to 1.12.x

AC 1.12.x	AC advanced settings 1.12.x	AC advanced settings 1.12.x

---

Verification passed on

Brave	1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

Scenario 1: - Before upgrade in 1.10.x

AC 1.10.97	AC advanced settings 1.10.x	AC advanced settings 1.10.x

After upgrade to 1.12.x, the proper values are used after 30 seconds

AC 1.12.x	AC advanced settings 1.12.x	AC advanced settings 1.12.x

Note: the 20 BAT value is not selected when dropdown is shown

This fixed after page reload

Scenario 2: - Before upgrade in 1.10.x

AC 1.10.x	AC advanced settings 1.10.x	AC advanced settings 1.10.x

After upgrade to 1.12.x, - the proper values are used after 30 seconds

AC 1.12.x	AC advanced settings 1.12.x	AC advanced settings 1.12.x

Note: the 100 BAT value is not selected when dropdown is shown

---

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

• Install 1.10.97. Enable Rewards. Modify all AC settings except monthly payment. Upgrade to 1.12.x. Confirmed Monthly payment is displayed on brave://rewards and AC settings as expected. Note - panel shows as described in https://bravesoftware.slack.com/archives/CB0KCRCQN/p1596633919026400?thread_ts=1596630882.025600&cid=CB0KCRCQN

• Install 1.10.97. Enable Rewards. Modify AC monthly payment setting only. Upgrade to 1.12.x. Confirmed Monthly payment is displayed on brave://rewards and AC settings as expected. Note - panel shows as described in https://bravesoftware.slack.com/archives/CB0KCRCQN/p1596633919026400?thread_ts=1596630882.025600&cid=CB0KCRCQN

• Install 1.11.104. Enable Rewards. Modify all AC settings except monthly payment. Upgrade to 1.12.x. Confirmed Monthly payment is displayed on brave://rewards and AC settings as expected. Note - panel displays as expected, no issues.

• Install 1.11.104. Enable Rewards. Modify AC monthly payment setting only. Upgrade to 1.12.x. Confirmed Monthly payment is displayed on brave://rewards and AC settings as expected. Note - panel displays as expected, no issues.