Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line arg to disable loading the brave rewards extension #1103

Closed
mkarolin opened this issue Sep 12, 2018 · 0 comments
Closed

Add command line arg to disable loading the brave rewards extension #1103

mkarolin opened this issue Sep 12, 2018 · 0 comments

Comments

@mkarolin
Copy link
Contributor

Description

Allow to provide command line arguments to npm start to disable loading Brave Rewards extension. This would facilitate debugging of the Brave Rewards extension by letting developers load the extension manually in dev mode.

CC @petemill @bsclifton @yrliou

Steps to Reproduce

  1. npm start -- --disable_brave_rewards_extension

Expected result:

When --disable_brave_rewards_extension is passed the extension is not shown in the Brave Actions Bar

@mkarolin mkarolin added this to the Releasable builds 0.55.x milestone Sep 12, 2018
@mkarolin mkarolin self-assigned this Sep 12, 2018
@bbondy bbondy closed this as completed in 1d69081 Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants