Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Search engine updates - Follow up to 10890 #11182

Closed
btlechowski opened this issue Aug 11, 2020 · 4 comments
Closed

[Desktop] Search engine updates - Follow up to 10890 #11182

btlechowski opened this issue Aug 11, 2020 · 4 comments

Comments

@btlechowski
Copy link

Follow up to #10890

Yahoo is not added in some locales
I marked this issue as OS/Linux only as @LaurenWags tested Sweden(#10890 (comment)) and it worked.

Steps to Reproduce

  1. Delete profile
  2. Run Brave with LANG=sv_SE.UTF-8 LANGUAGE=sv_SE /usr/bin/brave-browser --enable-logging=stderr
  3. Open brave://settings/searchEngines

Reproducible on:
Sweden (sv_SE)
Finland(fi_FI)

Not reproducible on:
France(fr_FR)
Spain (es_ES)

Actual result:

Yahoo is not included in the list
image

Expected result:

Yahoo is included in the list

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @bsclifton @rebron @deeppandya

@LaurenWags
Copy link
Member

Does not reproduce on macOS using

Brave | 1.12.108 Chromium: 84.0.4147.105 (Virallinen koontiversio) (64-bittinen)
-- | --
Päivitetty versio | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
Käyttöjärjestelmä | macOS Versio 10.14.6 (Build 18G3020)

Confirmed both Sweden and Finland work as expected.

@bsclifton bsclifton self-assigned this Aug 11, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 11, 2020
@rebron
Copy link
Collaborator

rebron commented Sep 11, 2020

@btlechowski Can you double check Windows? Per @LaurenWags above looks like macOS is working.

@btlechowski
Copy link
Author

btlechowski commented Sep 11, 2020

@GeetaSarvadnya was verifying #10890 on Windows.
@GeetaSarvadnya can you check this issue on Windows?

@bsclifton
Copy link
Member

Closing as Yahoo has been removed

@bsclifton bsclifton removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes QA/Test-Plan-Specified labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants