[Desktop] Sync v2 - Apps are not automatically installed

[btlechowski]

App is synced but the App is not installed

According to @darkdh this is an upstream bug

Steps to Reproduce

1. Clean install on DeviceA and DeviceB
2. Establish sync chain between DeviceA and DeviceB
3. Enable Apps sync on DeviceA and DeviceB
4. DeviceA: Open interia.pl
5. DeviceA: Click Install Interia in the URL field
6. Wait for sync update
7. DeviceB: Open interia.pl

Actual result:

DeviceB: App is synced

DeviceB : App is not installed

Expected result:

DeviceB : App is installed

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave	1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @darkdh @jsecretan @AlexeyBarabash @rebron

[jsecretan]

@AlexeyBarabash could you also file an upstream bug for this and see what they say?

[AlexeyBarabash]

@jsecretan yes, will do

[AlexeyBarabash]

@btlechowski @jsecretan
I could not reproduce it .
Got the app on device B.

[AlexeyBarabash]

On device B just then Right Button click on the icon INT and choose install - then all works.

[rebron]

@darkdh Is this an upstream bug?
@AlexeyBarabash I'm not sure what you mean here, @btlechowski is saying that it should be installed without having to do a right click on the icon to install. He's going to the url again and seeing a prompt to re-install the app and he shouldn't see that prompt at all.

[darkdh]

We already had this conversation in slack
https://bravesoftware.slack.com/archives/C2HJYB45N/p1598556672031500
And according to the code in chrome/browser/apps/app_service/app_icon_factory.h , it is intentional

  kPendingLocalLaunch = 0x20,  // Apps that are installed through sync, but
                               // have not been launched locally yet. They
                               // should appear gray until they are launched.

[AlexeyBarabash]

Closing as we have #11911 .