[Desktop] Use Greaselion for Github publishers

[NejcZdovc]

we should switch to GL for Github so that we can have faster turn around rate when something breaks.

[LaurenWags]

QA/Blocked on #12159

[LaurenWags]

the rate limiting error seen with #12159 is not occurring at the moment, however it should still be decided what to do if/when the rate limiting happens again.

removing QA/Blocked for now as this issue can currently be tested.

[LaurenWags]

Verification in progress with:

Brave	1.17.60 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision	37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS	macOS Version 10.14.6 (Build 18G6032)

Overall Notes for testing:

Test plan often references Verify that tip icon is inserted in expected locations. Per discussion with Emerick, these are the locations he provided:

  // Format: https://github.com/<user>/<repository>/pull/<pr_number>
  // Format: https://github.com/<user>/<repository>/issues/<issue_number>
  configureTipAction('timeline-comment-actions', commentInsertFunction)
  // Format: https://github.com/<user>/<repository>/commits/<branch_name>
  configureTipAction('js-commits-list-item', commitLinksInsertFunction)
  // Format: https://github.com/<user>?tab=stars
  configureTipAction('float-right', starringContainerInsertFunction)
  // Format: https://gist.github.com/<user>/<gist_number>
  configureTipAction('pagehead-actions', pageheadInsertFunction)
  // Format: https://github.com/orgs/<org>/people
  // Format: https://github.com/orgs/<org>/teams/<team_name>/members
  configureTipAction('member-list-item', memberListItemInsertFunction)

Pull Request

Verified STR from brave/brave-core#6789 for unverified publisher (using brave/brave-core#6743) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env). Also, logged #12520 for missing favicon:

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment (note, content is not displayed for a GH in-line tip as it is for Twitter/Reddit. This is logged with #5562):

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using LaurenWags/laurenwags.github.io#1) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Issue

Verified STR from brave/brave-core#6789 for unverified publisher (using #12013) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env):

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using LaurenWags/laurenwags.github.io#7) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Brave	1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision	37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS	macOS Version 10.14.6 (Build 18G6032)

Commits

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/brave/brave-browser/commits/master) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each commit:

Confirmed clicking on the in-line tip icon for a commit tips the author of the commit:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://github.com/laurenwags/laurenwags.github.io/commits/master) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays next to each commit:

Confirmed clicking on the in-line tip icon for a commit tips the author of the commit:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Starred Repos (must be logged in to GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/emerick?tab=stars) on a clean profile.

Confirmed expected publisher (in this case, the user) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each starred repo:

Confirmed clicking on the in-line tip icon tips the owner of the repo. Logged #12538 for misaligned hover text.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://github.com/laurenwags?tab=stars) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays next to each starred repo:

Confirmed clicking on the in-line tip icon tips the owner of the repo:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary. Tips to unverified publisher went to Pending list.

Organization Members (do not need to be logged into GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/orgs/brave/people) on a clean profile. Unable to verify this page for a verified publisher since there isn't a verified org set up on staging env.

Confirmed expected publisher (in this case, the org) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each user:

Confirmed clicking on the in-line tip icon for a user tips the selected user.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list. Confirmed tips to a verified publisher (via in-line tip button, not panel) go thru as expected and are displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Team Members (need to be logged into GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/orgs/brave/teams/legacy_qa/members) on a clean profile. Unable to verify this page for a verified publisher since there isn't a verified org set up on staging env.

Confirmed expected publisher (in this case, the org) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each user:

Confirmed clicking on the in-line tip icon tips the selected user.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list. Confirmed tips to a verified publisher (via in-line tip button, not panel) go thru as expected and are displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Gist

Verified STR from brave/brave-core#6789 for unverified publisher (using https://gist.github.com/darkdh/85fed2542190510aaee0f3ad91091818) on a clean profile.

Confirmed expected publisher (in this case, the user) is displayed in the panel (on staging env):

Confirmed in-line tip button displays in the page header:

Confirmed clicking on the in-line tip icon tips the author of the gist:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://gist.github.com/LaurenWags/b22c1b0f1f8bace284f9d9c5bc36d3b9) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays in the page header:

Confirmed clicking on the in-line tip icon tips the author of the gist:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary. Tips to unverified publisher went to Pending list.

Excluded URLs

Verified STR from brave/brave-core#6789 for https://github.com/about
Confirmed expected publisher information in the URL (github.com)
Confirmed tips went to github.com and to Pending list as GH is not verified.

Spot checked other pages (from https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/github/utils.ts#L57-L76) as well:

Logged #12544 for the following pages not having publisher info in the panel (expected github.com in the panel for the following pages):
github.com/features/code-review
github.com/security
github.com/collections

Note, there may be others, the above are just the ones I encountered.

Activity

Verified STR from brave/brave-core#6789

Per #12454 (comment) this will be implemented with #12107

History

Verified STR from brave/brave-core#6789

Confirmed after visiting many GH pages in the same tab, after using back/forward navigation buttons and clicking on the BAT logo from panel/in-line tip button (where available), expected publisher info was displayed in the panel and tip banners.

Also confirmed publishers showed expected verification status (verified or not verified).

Tab Activation

Verified STR from brave/brave-core#6789 on a clean profile

Confirmed after opening many GH pages in different tabs (a mix of URL types mentioned above), after selecting a page and clicking on the BAT logo from panel/in-line tip button (where available), expected publisher info was displayed in the panel and tip banners.

Also confirmed publishers showed expected verification status (verified or not verified).

Tipping non GitHub creators

Verified STR from brave/brave-core#6789 on a clean profile

Confirmed able to tip each of the following other types of verified publishers: regular sites, YouTube, Twitch, Reddit, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.
Checked one time and recurring tipping for the various publisher types listed above:

Regular site:

YouTube:

Twitch:

Reddit:

Twitter:

---

Verification passed on

Brave	1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
Revision	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

Pull Request

Verified STR from brave/brave-core#6789 for unverified publisher (using brave/brave-core#6743) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env).

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment (note, content is not displayed for a GH in-line tip as it is for Twitter/Reddit. This is logged with #5562):

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using LaurenWags/laurenwags.github.io#1) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Issue

Verified STR from brave/brave-core#6789 for unverified publisher (using #12013) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env):

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using LaurenWags/laurenwags.github.io#7) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays on comment areas:

Confirmed clicking on the in-line tip icon for a comment tips the author of the comment:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Commits

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/brave/brave-browser/commits/master) on a clean profile.

Confirmed expected publisher (in this case, the organization) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each commit:

Confirmed clicking on the in-line tip icon for a commit tips the author of the commit:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://github.com/laurenwags/laurenwags.github.io/commits/master) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays next to each commit:

Confirmed clicking on the in-line tip icon for a commit tips the author of the commit:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Starred Repos (must be logged in to GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/emerick?tab=stars) on a clean profile.

Confirmed expected publisher (in this case, the user) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each starred repo:

Confirmed clicking on the in-line tip icon tips the owner of the repo. Encountered #12538 for misaligned hover text.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://github.com/laurenwags?tab=stars) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays next to each starred repo:

Confirmed clicking on the in-line tip icon tips the owner of the repo:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary. Tips to unverified publisher went to Pending list.

Organization Members (do not need to be logged into GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/orgs/brave/people) on a clean profile. Unable to verify this page for a verified publisher since there isn't a verified org set up on staging env.

Confirmed expected publisher (in this case, the org) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each user:

Confirmed clicking on the in-line tip icon for a user tips the selected user.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list. Confirmed tips to a verified publisher (via in-line tip button, not panel) go thru as expected and are displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Team Members (need to be logged into GH)

Verified STR from brave/brave-core#6789 for unverified publisher (using https://github.com/orgs/brave/teams/legacy_qa/members) on a clean profile. Unable to verify this page for a verified publisher since there isn't a verified org set up on staging env.

Confirmed expected publisher (in this case, the org) is displayed in the panel (on staging env):

Confirmed in-line tip button displays next to each user:

Confirmed clicking on the in-line tip icon tips the selected user.

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list. Confirmed tips to a verified publisher (via in-line tip button, not panel) go thru as expected and are displayed on brave://rewards, brave://rewards-internals, and Monthly Summary.

Gist

Verified STR from brave/brave-core#6789 for unverified publisher (using https://gist.github.com/darkdh/85fed2542190510aaee0f3ad91091818) on a clean profile.

Confirmed expected publisher (in this case, the user) is displayed in the panel (on staging env):

Confirmed in-line tip button displays in the page header:

Confirmed clicking on the in-line tip icon tips the author of the gist:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the unverified publisher went to Pending list.

Verified STR from brave/brave-core#6789 for verified publisher (using https://gist.github.com/LaurenWags/b22c1b0f1f8bace284f9d9c5bc36d3b9) on a clean profile.

Confirmed expected publisher (in this case, me) is displayed in the panel (on staging env).
Confirmed checkmark appears on BAT logo for verified publisher.

Confirmed in-line tip button displays in the page header:

Confirmed clicking on the in-line tip icon tips the author of the gist:

Confirmed able to tip from panel and in-line tip button on this page. Confirmed tips to the verified publisher went thru as expected and were displayed on brave://rewards, brave://rewards-internals, and Monthly Summary. Tips to unverified publisher went to Pending list.

Excluded URLs

Verified STR from brave/brave-core#6789 for https://github.com/about
Confirmed expected publisher information in the URL (github.com)
Confirmed tips went to github.com and to Pending list as GH is not verified.

Spot checked other pages (from https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/github/utils.ts#L57-L76) as well:

Encountered #12544 for the following pages not having publisher info in the panel (expected github.com in the panel for the following pages):
github.com/features/code-review
github.com/security
github.com/collections

Note, there may be others, the above are just the ones I encountered.

Activity

Verified STR from brave/brave-core#6789

Per #12454 (comment) this will be implemented with #12107

History

Verified STR from brave/brave-core#6789

Confirmed after visiting many GH pages in the same tab, after using back/forward navigation buttons and clicking on the BAT logo from panel/in-line tip button (where available), expected publisher info was displayed in the panel and tip banners.

Also confirmed publishers showed expected verification status (verified or not verified).

Tab Activation

Verified STR from brave/brave-core#6789 on a clean profile

Confirmed after opening many GH pages in different tabs (a mix of URL types mentioned above), after selecting a page and clicking on the BAT logo from panel/in-line tip button (where available), expected publisher info was displayed in the panel and tip banners.

Also confirmed publishers showed expected verification status (verified or not verified).

Tipping non GitHub creators

Verified STR from brave/brave-core#6789 on a clean profile

Confirmed able to tip each of the following other types of verified publishers: regular sites, YouTube, Twitch, Reddit, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.
Frequently encountered #6851
Checked one time and recurring tipping for the various publisher types listed above:

Regular site:

YouTube:

Twitch:

Reddit:

Twitter: