Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] macOS unfocused window minor UI polish issues #11682

Open
dndrsn opened this issue Sep 11, 2020 · 4 comments
Open

[Desktop] macOS unfocused window minor UI polish issues #11682

dndrsn opened this issue Sep 11, 2020 · 4 comments
Labels
OS/Desktop OS/macOS polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@dndrsn
Copy link

dndrsn commented Sep 11, 2020

Description

On macOS, when a Brave window does not have focus, there are a couple minor UI issues:

  1. the window "stoplight" buttons are almost imperceptible
  2. the bookmark URL bar icon does not show the "unfocused" state consistent to the other icons next to it

Steps to Reproduce

  1. Open a Brave browser window
  2. Focus on another application or another Brave browser window with the previous window still visible

Actual result:

image
Notice that the stoplights have almost no contrast with the window chrome.
Also notice that the bookmark icon is not "dimmed" like the others

Expected result:

For the "stoplight" buttons something more like the OS default:
image
or like Chrome:
image

For the bookmarks button, the same lower contrast styling as other buttons.

Reproduces how often:

Easily, always.

Brave version (brave://version info)

1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Unknown
  • Can you reproduce this issue with the nightly channel?
    Unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A (no)
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A (no)
  • Is the issue reproducible on the latest version of Chrome?
    N/A (no)

Miscellaneous Information:

@rebron rebron added the polish Nice to have — usually related to front-end/visual tasks label Oct 16, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 16, 2020

@dndrsn What macOS version are you on? I think we're seeing this same issue on Catalina 10.15.7. I'm not seeing the same on Big Sur though.

@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. OS/macOS labels Oct 16, 2020
@dndrsn
Copy link
Author

dndrsn commented Oct 16, 2020

@rebron I am currently using Catalina 10.15.7.

@kjozwiak
Copy link
Member

@rebron I am currently using Catalina 10.15.7.

Seeing the same on my machine which is on Catalina 10.15.7 as well. Example:

Screen Shot 2020-10-16 at 1 50 42 PM

It's really hard to see the buttons on Brave once it's backgrounded compared to the other applications. Sounds like it was possible fixed/addressed in Big Sur as per @rebron's above comment.

@LaurenWags when you have a few minutes, mind checking to see if you're seeing the same thing on Mojave?

@LaurenWags
Copy link
Member

@kjozwiak reproduces on Mojave, dark theme looks better than light theme, but both have the Bookmark icon non-dimmed.

Light theme:
Light

Dark theme:
Dark

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.14.6 (Build 18G6032)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop OS/macOS polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Development

No branches or pull requests

4 participants