Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new panel design for tipping #11929

Closed
NejcZdovc opened this issue Sep 30, 2020 · 1 comment · Fixed by brave/brave-core#6890
Closed

Implement new panel design for tipping #11929

NejcZdovc opened this issue Sep 30, 2020 · 1 comment · Fixed by brave/brave-core#6890
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@NejcZdovc
Copy link
Contributor

design can be found here https://www.figma.com/file/Zsc9KCXEg93XMOoFEHuBV3/Rewards-Everywhere--stopgap?node-id=0%3A1
@NejcZdovc NejcZdovc mentioned this issue Sep 30, 2020
Closed
15 tasks
@zenparsing zenparsing mentioned this issue Oct 20, 2020
Merged
33 tasks
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Oct 23, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 25, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
Revision	0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#6890
Confirmed designs from https://www.figma.com/file/EDGI52tfWG1ggC9ZYFguXy/tipping-banner-2.0?node-id=489%3A9872 per PR description.

Confirmed able to set monthly tip by selecting "Set" from the panel

Screenshots initial panel set monthly tip monthly tip confirmation

Confirmed panel reflects the monthly tip amount I set

Screenshots panel 1 panel expanded

Select Change Amount from drop down and change the tip amount

Screenshots select Change Amount

Confirm monthly tip amount is changed on panel and brave://rewards

Screenshots change shows on panel change shows on rewards page

Select Cancel from drop down on panel

Screenshots panel expanded select cancel

Cancel monthly tip

Screenshots cancel on banner removed from rewards page panel returns to before

Verification passed on


Brave | 1.18.66 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verified test plan from brave/brave-core#6890
Confirmed designs from https://www.figma.com/file/EDGI52tfWG1ggC9ZYFguXy/tipping-banner-2.0?node-id=489%3A9872 per PR description.

Confirmed able to set monthly tip by selecting "Set" from the panel

Screenshots

image
image
image

Confirmed panel reflects the monthly tip amount I set

Screenshots

image
image

Select Change Amount from drop down and change the tip amount

Screenshots

image

Confirm monthly tip amount is changed on panel and brave://rewards

Screenshots

image
image

Select Cancel from drop down on panel

Screenshots

image
image

Cancel monthly tip

Screenshots

image

@rebron rebron changed the title [Desktop] Implement new panel design Implement new panel design for tipping Dec 7, 2020
@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Update monthly contribution drop down in rewards panel brave/brave-core
4 participants
@zenparsing @NejcZdovc @LaurenWags @GeetaSarvadnya