Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message on UI when failed to launch IPFS daemon in brave://ipfs #11976

Closed
yrliou opened this issue Oct 2, 2020 · 1 comment · Fixed by brave/brave-core#8203
Closed

Comments

@yrliou
Copy link
Member

yrliou commented Oct 2, 2020

We should show some error messages to let user know that we failed to do the action when they try to launch IPFS daemon using the launch button in brave://ipfs, otherwise they might be confused that whether the button is working or not.

@stephendonner
Copy link

Verified PASSED with nightly using the testplan in brave/brave-core#8203 and brave/brave-core#8219 with build

Brave 1.23.39 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

I took care of the installation error-message verification over in #13170; for the launch error-message verification, I did the following:

Steps:

  1. new profile
  2. loaded brave://ipfs
  3. launched Apple's Network link conditioner tool
  4. clicked the Install and start on the ipfs page; let installation and launch finish
  5. clicked the Stop button on the ipfs node page
  6. chose 100% packet loss profile from the Network link conditioner tool
  7. clicked the Start button on the ipfs node page
  8. confirmed that we got An error occurred; please try to launch again error message
  9. quit network-conditioning tool
  10. clicked Start again on the ipfs node page

Confirmed that after some time (need to wait for the link to be re-established), the node successfully relaunched on its own.

ipfs-launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants