-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puzzle icon for autoplay to an autoplay specific icon #1203
Comments
looks like different icons on chrome://settings/content |
yeah, i think those are generated by iron icons which pulls from a different place than the omnibox, so we should prob break those changes out into another issue, some of them might get or be partially resolved with clifton's settings updates |
This issue seems to now have a broad scope for all ombnibox permission icons, but brave/brave-core#548 is only addressing autoplay and the generic extension icon, right @rossmoody ? |
Verification Passed on
Went through verification using the following build under
Verification Passed on
|
@rossmoody quick question regarding our current icon set while using the dark theme. Is there plans to incorporate a white set of icons for the dark theme? They're pretty hard to see with the current set when using the dark theme.. Example: |
I agree, Bookmark icons as well. Would like to switch the shield alert circle to purple in dark theme instances as well. There is a huge list of UI adjustments on the docket but shields/rewards are consuming all atm. |
@rossmoody sounds good! Appreciate the update. Guessing there's no need to create issues. Sounds like it's on the list of things to do 👍 |
Description
Currently using puzzle icon with red x mark. Need an autoplay specific icon.
Related
#699
Test plan
Visit https://tesla.com/model3
![image](https://user-images.githubusercontent.com/741836/46509750-70ea7d80-c7f9-11e8-821f-65265a99218e.png)
Autoplay blocked icon should look like:
The text was updated successfully, but these errors were encountered: