Brave Ads landed events should only be triggered if the user clicked the ad

[tmancey]

Description

Brave Ads landed events should only be triggered if the user clicked the ad

Steps to Reproduce

1. View an ad notification
2. Navigate to the same page as the target url for the ad (without relaunching the browser)

Actual result:

Confirmation is triggered for landed event

Expected result:

Confirmation should not be triggered for landed event

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[btlechowski]

Verification passed on

Brave	1.17.68 Chromium: 87.0.4280.49 (Oficjalna wersja) (64-bitowa)
Wersja	f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
System operacyjny	Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description
Ad was shown:

[14288:4528:1116/052809.010:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: cdd70f65-090f-478f-966c-49467da25895
  creativeInstanceId: 31bba57c-7c17-4bad-9ede-68346b9602c4
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: Hotel Deals Club
  body: Winter is coming, ready to get away? Global hotels up to 80% off.
  targetUrl: https://travala.com/

Opened targetUrl in a new tab. Verified landed event was not triggered:

[14288:4528:1116/052833.620:VERBOSE1:ads_impl.cc(1334)] Visited URL does not match the last clicked ad

Clicked the ad.

[14288:4528:1116/052914.080:VERBOSE3:ad_notification_event_clicked.cc(31)] Clicked ad notification with uuid cdd70f65-090f-478f-966c-49467da25895 and creative instance id 31bba57c-7c17-4bad-9ede-68346b9602c4

Verified landed event is triggered after clicking the ad

[14288:4528:1116/052938.361:VERBOSE1:ads_impl.cc(1338)] Visited URL matches the last clicked ad
[14288:4528:1116/052938.362:VERBOSE1:ads_impl.cc(1374)] Start timer to sustain ad for https://travala.com/ which will trigger in 0 godzin, 0 minut i 10 sekund at 05:29
[14288:4528:1116/052948.362:VERBOSE1:ads_impl.cc(1388)] Sustained ad for https://travala.com/
[14288:4528:1116/052948.362:VERBOSE1:confirmations.cc(89)] Confirming landed ad for creative instance id 31bba57c-7c17-4bad-9ede-68346b9602c4

---

Verified passed with

Brave	1.17.69 Chromium: 87.0.4280.60 (Official Build) (x86_64)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from the description

Ad was shown:

[11011:775:1117/084757.233016:VERBOSE1:ads_impl.cc(1149)] Ad notification shown:
  uuid: 99763478-cad0-435c-9190-79d90ef66080
  creativeInstanceId: 59998da4-c048-45ad-87dc-d846bc058cd3
  creativeSetId: 32439113-32d2-4b50-9497-405b7eedd1d5
  campaignId: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
  category: untargeted
  title: HOOCH
  body: HOOCH APP, join today and save up to 70% worldwide.
  targetUrl: https://travala.com/

Opened targetUrl in a new tab. Verified landed event was not triggered:

[11011:775:1117/084813.877785:VERBOSE1:ads_impl.cc(1334)] Visited URL does not match the last clicked ad

Closed the tab with this URL.
Clicked the ad.

[11011:775:1117/084823.368977:VERBOSE3:ad_notification_event_clicked.cc(31)] Clicked ad notification with uuid 99763478-cad0-435c-9190-79d90ef66080 and creative instance id 59998da4-c048-45ad-87dc-d846bc058cd3
[11011:775:1117/084823.370328:VERBOSE1:confirmations.cc(89)] Confirming click ad for creative instance id 59998da4-c048-45ad-87dc-d846bc058cd3

Verified landed event is triggered after clicking the ad

[11011:775:1117/084824.374656:VERBOSE1:ads_impl.cc(1338)] Visited URL matches the last clicked ad
[11011:775:1117/084824.374854:VERBOSE1:ads_impl.cc(1374)] Start timer to sustain ad for https://travala.com/ which will trigger in 0 hours, 0 minutes, 10 seconds at 8:48 AM

[11011:775:1117/084834.375242:VERBOSE1:ads_impl.cc(1388)] Sustained ad for https://travala.com/
[11011:775:1117/084834.375821:VERBOSE1:confirmations.cc(89)] Confirming landed ad for creative instance id 59998da4-c048-45ad-87dc-d846bc058cd3

---