Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] incorrect reddit creator information displayed on panel #12302

Closed
LaurenWags opened this issue Oct 23, 2020 · 2 comments
Closed

[Desktop] incorrect reddit creator information displayed on panel #12302

LaurenWags opened this issue Oct 23, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 23, 2020

Description

Incorrect reddit creator information can be displayed on the panel. It seems to happen when using back/forward navigation arrows between subreddits/posts and opening the panel although there could be other cases.

Steps to Reproduce

  1. Clean profile, enable rewards (staging env)
  2. Navigate to https://www.reddit.com/r/brave_browser/
  3. Click on pinned post "Regarding Rewards Support (PLEASE READ)"
  4. At the top where it says "Posted by u/Brave_Support" click on "u/Brave_Support"
  5. When you're on https://www.reddit.com/user/Brave_Support/ open the panel, confirm you see "Brave_Support on Reddit"
  6. Close panel.
  7. Click back arrow 2x, you should be back to https://www.reddit.com/r/brave_browser/
  8. Open panel.

Actual result:

panel should just say reddit.com, not Brave_Support on Reddit.
Screen Shot 2020-10-23 at 3 36 16 PM

Page refresh fixes the above issue, however if you don't refresh the page and you open other posts on this page, they will all say "Brave_Support on Reddit", ex:
Screen Shot 2020-10-23 at 3 52 49 PM

Expected result:

just reddit.com since afaik only users are supported for Rewards:
Screen Shot 2020-10-23 at 3 53 44 PM

Reproduces how often:

100% with above steps

Brave version (brave://version info)

Brave 1.17.48 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce on 1.15.x
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @emerick

@LaurenWags
Copy link
Member Author

Other STR:

Navigate to a sub reddit like https://www.reddit.com/r/AnimalsBeingJerks/
Note who the most recent post (at the top) is from, ex: opus1123:
Screen Shot 2020-10-28 at 10 30 18 AM
Scroll down a bit and click on a post by someone else, ex: this one is from tyrannosau_ris:
Screen Shot 2020-10-28 at 10 31 46 AM
Once the post loads, open the panel.
Was expecting tyrannosau_ris, but see opus1123:
Screen Shot 2020-10-28 at 10 31 08 AM

Refreshing the page fixes this.

@LaurenWags
Copy link
Member Author

+1 from #9136 (comment)

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants