-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot delete sites from "Sites that can always use cookies" #12375
Comments
cc: @jumde Related to the google login exceptions? |
@aperullo - Are you still seeing this if |
@jumde Yeah, the issue persists when that setting is toggled off or on. Even after restarting the browser. One of the stuck sites is almost certainly not using Google login either, as its a microsoft domain. Please let me know how else I can help. |
Seems to be a duplicate of #11259 |
Same behaviour on Linux 1.16.68 x86_64 |
Same behaviour on Mac 1.16.72 Chromium: 86.0.4240.183 (Official Build) (x86_64) |
Similar issue here Version 1.16.72 Chromium: 86.0.4240.183 (Offizieller Build) (64-Bit). There are three entries in the "Sites that can always use cookies" section that cannot be removed. They are also the only entries with a (not functioning) garbage can icon instead of a three dot menu. Even worse, they allow third party cookies which I have never done. Whenever I manually add entries I either used the cookies menu in the menu that pops up when you click the lock icon to the left of the url bar (which has no way of enabling all third party cookies) or use the "add" button on the cookies page and make sure the check box for third party cookies is unchecked. The settings are also active and not just some visual bug, I checked by closing and opening the browser again and found that there are still cookies of those websites saved even though the default setting of my browser is to delete all cookies. |
Same behaviour on Version 1.17.73 Chromium: 87.0.4280.67 (Official Build) (64-bit) |
SOLUTION on Brave Browser Linux. |
@rotatingangles it's definitely not intentional! Thanks for sharing a work-around cc: @rebron @karenkliu |
This is still happening on Version 1.18.78 Chromium: 87.0.4280.141 (Official Build) (64-bit) and Version 1.19.77 Chromium: 87.0.4280.101 (Official Build) beta (64-bit) on Windows10 x64 20H2. As well if you add google.com to the list of sites under Always clear cookies when windows are closed the various subcookies are not being deleted. If they were then one would be logged out of Gmail and you are not. When Brave is started after being closed you are remained logged into Gmail. None of the sub cookies that are part of Google.com are being deleted. In particular, the SID subcookie that is under Google.com is NOT being deleted when Brave is shutdown. If it was then when one went to Gmail.com after closing and restarting Brave then you would find that you would be logged out. This deletion of Google.com sub cookies works fine in MS Edge Chromium and Google Chrome. |
This is still happening for me as well on Arch Linux 5.10.7-arch1-1 with brave-bin 1:1.19.86-1. It happens in the "always allow" and "never allow" sections. |
Still a problem in Version 1.19.92 Chromium: 88.0.4324.152 (Official Build) (64-bit) |
I am also tagging this issue #9085 as it too is cookie deletion related but on exit of the browser. |
didn't work. |
I have sites that I cannot delete in both Sites that can always use cookies and Sites that can never use cookies and interestingly I have one stuck in both that is preventing me from using the website in Brave. Any way to adjust these settings from outside of brave? |
|
Hey guys, can confirm that this been a problem on Mac OS and Windows for a while now. Here is the thread in the BraveCommunity Forums and my (inconvenient) workaround: I think this is WAY more critical than the P3 rating that it was given by @rebron. As I describe there, the Sync Chain can be a big part of the problem. Even after deleting the entries from the
|
How is this issue STILL not resolved? This is embarrassing, Brave, and it's not worth sticking with your browser over. |
Have given up on reporting issues with Brave myself. It gets frustrating after spending countless hours testing and providing feedback and hearing crickets. Really tiring shouting into the wind. |
At this point afaik the only cookie settings that cannot be deleted are the ones that are created by disabling shields on a site or the pref to allow google logins and that is by design. Deleting those settings would leave things in a confusing state where it looks like shields is down, but it's only partially down because 3p cookies are still blocked. The fix here is to show those settings as coming from another source (similar to settings created by extensions). To remove those settings you need to navigate to the site and re-enable shields. Nightly and beta have added shields to |
also the shields generated cookie settings should not show up as editable in the cookies UI (similar to how extension created settings works) |
If anyone has a case where settings that were not adding by disabling shields or the google login pref cannot be deleted then that's something we need to look into, but otherwise I think this issue can be closed and a new issue opened up for properly displaying those settings as non-editable |
Well, I posted this issue regarding Google-specific cookie deletion almost 2 years ago #9085. I haven't tried the normal deletion in Brave because I found a 3rd party extension that works to delete the cookie. Frankly, I am tired/frustrated spending hours testing and posting feedback regarding Brave issues and hearing crickets. I have resigned myself to putting up with the current quirks in Brave until my patience wears out and I switch browsers. |
I have the same issue on the newest version of Brave. I looked at the HTML code associated with the trash can symbol. There is no code to execute, so clicking the icon does nothing. Not very trustworthy of the Brave team to be allowing this. |
@Rob-Garner I'm not sure what you're looking at, but the problem is definitely not that code does not execute when you click on the trashcan. The problem is that it doesn't always correctly delete cookie settings that were generated by shields. I'm also not sure what's untrustworthy about this because they are your settings that you selected and they can be changed in the shields panel. |
I had this issue in v1.47.171 used the method of disabling google login in brave://settings/socialBlocking and it worked. |
Today is 2023-03-19, 2½ years after this was 1st reported here, and this issue still HAS NOT BEEN RESOLVED !!!!! I am on macOS. This is a privacy issue of a browser that claims to be focused on privacy. Yeah, sure 🤣 If it is only done when convenient, then stop marketing yourself as a privacy focused browser: you can't have your cake and eat it. |
Tbh, it has been some months since I gave up on this issue. As mentioned above, the issue is somehow related to the shields. |
This is still an issue three plus years later.. as far as I'm concerned this is a data breach allowing cookies to track me and no way to stop it easily.. Chrome and/or Brave browsers are frauds... |
I know I probably forgot what I did with some sites, but sometimes I literally just start a completely new instance or guest mode because I have no clue what I did to break a site from working properly. It might still relate to this. |
@bridiver The issue with the Shields UI is that you need to be on the site to change the settings. This is sometimes very difficult because those domains or hostnames have since setup 301 or 308 redirects making it nearly impossible to change settings for the site through the Shields UI. This is how I ended up following this issue actually. There was more than one site which I had added exceptions for in the past that were very difficult if not impossible to use Shields UI on at some point in the future. |
@drstevens Agree. I'm in the same situation with redirected sites. |
Understood and this is one of the reasons why I wanted to keep the chromium cookie settings UI, but the interaction between the two can be complicated and we need to come up with a better solution. Another issue that complicates the situation is that shields cookie settings do not get persisted as chromium cookie settings. They are dynamically added/removed as chromium cookie settings at runtime so they can be disabled when shields is down without losing the shields up setting. If you disable shields for a site the rules will disappear from the chromium cookie settings, but they are only disabled, not removed. I think the solution here is likely going to be replacing the chromium cookie settings UI with a shields cookie settings UI, but then there's an issue with how to handle existing chromium cookie settings that were not added through shields. The only really useful thing you could do with chromium cookie settings that can't be done with shields cookie settings is block or allow a third party site and on all first party domains, but I don't think that's really a meaningful setting with ephemeral storage/third party storage partitioning. Cc @pes10k |
So after more discussion the tentative plan is to make two changes:
|
@bridiver Thanks for the update. Love the browser and appreciate all that the Brave team does. |
I found something that worked for me on the MacOS Brave browser (at least regarding deleting the sites). The same list of sites that is present in Privacy and security > Cookies and other site data > Sites that can always use cookies ( The latter is where I was able to successfully remove sites. After doing so, all the sites were removed from both areas. Hope that helps; sorry if this comment is superfluous or doesn't work for others. |
This fixed it for me... Go to brave://settings/socialBlocking and TOGGLE OFF all 4. |
Is this still an issue now that the Google Login button is gone from social settings (and there is no dedicated social settings page)? |
Yes, I still cannot delete sites from, for example, Sites allowed to use third-party cookies. |
The chromium cookie interface has been going through a lot of strange changes recently and we're thinking we just need to dump the upstream UI completely so we can handle these correctly. Chromium cookie settings are now split between cookies and site data and it's very confusing imo. |
Also having this issue. No console messages exist when clicking the trashcan icon. I have tried the |
Description
Sites cannot be deleted from the "always allow cookies" list, only added
Steps to Reproduce
Actual result:
Nothing occurs and the site remains
Expected result:
The site should be deleted
Reproduces how often:
Consistent
Brave version (brave://version info)
1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit) b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS
Windows 10 64-bit
The text was updated successfully, but these errors were encountered: