Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked elements via CSS selector should be shown on brave://adblock or on a custom page #1280

Closed
srirambv opened this issue Sep 26, 2018 · 13 comments
Labels
closed/wontfix feature/brave-pages feature/CSS-element-block feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@srirambv
Copy link
Contributor

Description

Blocked elements via CSS selector should be shown on chrome://adblock

Steps to Reproduce

  1. Visit any site and block an element via CSS selector on context menu
  2. If your memory serves you well, good for you, if not you'll forget what you have blocked on the site
  3. Someone else reports that ads/page elements are not blocked for the same site and you start to wonder why others can see but you can't

Actual result:

Blocked elements via CSS selector is not listed anywhere making it hard to remember what is blocked on a site

Expected result:

Would be nice to list the items blocked on site under chrome://adblock

Reproduces how often:

Easy

Brave version (chrome://version info)

All

Reproducible on current release:

Doesn't apply since its block option is not there

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the 1.x Backlog milestone Sep 26, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 28, 2018
@Brave-Matt
Copy link

+1million for this. This feature has a lot of potential if it gets fleshed out.

@srirambv srirambv changed the title Blocked elements via CSS selector should be shown on chrome://adblock or on a custom page Blocked elements via CSS selector should be shown on brave://adblock or on a custom page Oct 26, 2018
@bbondy bbondy added feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings and removed feature/global-settings Settings at browser level independent of shields settings labels Oct 31, 2018
@tildelowengrimm
Copy link
Contributor

Sounds like we need to implement some front-end UI for this functionality?

@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 31, 2018
@Brave-Matt
Copy link

@tomlowenthal agreed!
Would also be cool if, after selecting it from the context menu, the pointer highlighted/outlined the element it's looking at. Kind of like the inspector.

Would help people block what they want without having to know or dig through any css.

@srirambv
Copy link
Contributor Author

srirambv commented Nov 6, 2018

+1 on the highlighting the element to be blocked.

@Brave-Matt
Copy link

From Community:
image

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@igneosaur
Copy link

Blocking elements doesn't even work for me at the moment. Ads are back when you refresh, CSS classnames don't change or anything.

@egid
Copy link

egid commented Apr 12, 2019

I'm seeing the exact same problem @igneosaur is reporting. When blocking, the inspector shows 'injected styles'; on reload, they are not applied.

@eljuno
Copy link

eljuno commented Apr 21, 2019

@bernieke
Copy link

For me the block only lasts a while. Every few days or so I need to re-apply it for some reason.

Even just a simple txt page which shows the rules and the sites (or is it pages?) they are applied to would be extremely helpful! Or even just some commandline command to extract the same from the config somehow?

@bsclifton
Copy link
Member

@bernieke that makes sense - we aren't persisting the rules to disk (right now, it's only stored in local storage). If your cookies get cleared, it'll delete the rules

A requirement for this task would be that the rules should be persisted to disk or at least in a similar manner to custom ABP rules

@veekas
Copy link

veekas commented Aug 13, 2019

@bsclifton persistent storage would be great!

@bsclifton
Copy link
Member

Closing as wontfix - we have a new cosmetic filter in place. You can put cosmetic filter rules on brave://adblock now 😄It's live in version 1.7 and newer.

I created #8914 to track removing this older version

@Cral-Cactus
Copy link

When you clear in brave://adblock custom css it still apply but just gone from textbox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/brave-pages feature/CSS-element-block feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
None yet
Development

No branches or pull requests