Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance and refactor the Brave Ads component updater #12856

Closed
moritzhaller opened this issue Nov 23, 2020 · 3 comments · Fixed by brave/brave-core#8502
Closed

Enhance and refactor the Brave Ads component updater #12856

moritzhaller opened this issue Nov 23, 2020 · 3 comments · Fixed by brave/brave-core#8502
Assignees
@moritzhaller
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.25.x - Release

Comments

@moritzhaller
Copy link

moritzhaller commented Nov 23, 2020 •
edited
Loading

This ticket includes:

  • Enable a/b testing different versions of a resource, e.g. text classifier.
  • Refactor the Brave Ads component updater: Change name from "user model" to "ads resource" and move code into the brave ads component.
  • Remove bat-native-usermodel dependency from ads.
@moritzhaller moritzhaller self-assigned this Nov 23, 2020
@moritzhaller moritzhaller added feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Nov 23, 2020
@moritzhaller moritzhaller changed the title Wrap ad-matching models with base::feature and enable a/b testing of different versions of the same model Wrap ad-matching models with base::feature and enable a/b testing of different model versions Nov 23, 2020
@moritzhaller
Copy link
Author

cc @dimmu

@moritzhaller moritzhaller changed the title Wrap ad-matching models with base::feature and enable a/b testing of different model versions Enable a/b testing of different model versions Dec 19, 2020
@tmancey tmancey removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Mar 6, 2021
@tmancey tmancey changed the title Enable a/b testing of different model versions Implement a/b testing for text classification Mar 12, 2021
@moritzhaller moritzhaller self-assigned this Apr 1, 2021
@moritzhaller moritzhaller changed the title Implement a/b testing for text classification Enhance and refactor the Brave Ads component updater Apr 13, 2021
@moritzhaller moritzhaller mentioned this issue Apr 13, 2021
Merged
24 tasks
@moritzhaller moritzhaller added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Apr 13, 2021
@moritzhaller moritzhaller added this to the 1.25.x - Nightly milestone Apr 13, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 17, 2021
@btlechowski
Copy link

btlechowski commented May 24, 2021 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8502
Used en_US locale

Verified 1.25.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.1 was downloaded
image

Verified resources were loaded

[22081:22081:0524/124704.390366:VERBOSE1:resource_component.cc(104)] Registering Brave Ads Resources (US) with id iblokdlgekdjophgeonmanpnjihcjkjj
[22081:22081:0524/124704.390576:VERBOSE1:resource_component.cc(123)] Registering Brave Ads Resources (en) with id ocilmpijebaopmdifcomolmpigakocmo

[22081:22081:0524/124704.624767:VERBOSE1:resource_component.cc(212)] Adding resource bejenkminijgplakmkmcgkhjjnkelbld version 1
[22081:22081:0524/124704.624782:VERBOSE1:resource_component.cc(212)] Adding resource mkdhnfmjhklfnamlheoliekgeohamoig version 1
[22081:22081:0524/124704.624792:VERBOSE1:resource_component.cc(218)] Notifying resource observers
[22081:22081:0524/124704.625965:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.1/kkjipiepeooghlclkedllogndmohhnhi
[22081:22081:0524/124704.626136:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.1/xgauimuqostzbswdrrduxadfbhwrngio
[22081:22081:0524/124704.628224:VERBOSE1:purchase_intent_resource.cc(44)] Successfully loaded bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[22081:22081:0524/124704.630670:VERBOSE1:purchase_intent_resource.cc(221)] Parsed purchase intent resource version 1
[22081:22081:0524/124704.630805:VERBOSE1:purchase_intent_resource.cc(56)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[22081:22081:0524/124704.630869:VERBOSE1:anti_targeting_resource.cc(43)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[22081:22081:0524/124704.632282:VERBOSE1:anti_targeting_resource.cc(115)] Parsed anti targeting resource version 1
[22081:22081:0524/124704.632384:VERBOSE1:anti_targeting_resource.cc(53)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[22081:22081:0524/124705.071049:VERBOSE1:resource_component.cc(212)] Adding resource feibnmjhecfbjpeciancnchbmlobenjn version 1
[22081:22081:0524/124705.071063:VERBOSE1:resource_component.cc(218)] Notifying resource observers
[22081:22081:0524/124705.073728:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/ocilmpijebaopmdifcomolmpigakocmo/1.0.1/emgmepnebbddgnkhfmhdhmjifkglkamo
[22081:22081:0524/124705.153956:VERBOSE1:text_classification_resource.cc(48)] Successfully loaded feibnmjhecfbjpeciancnchbmlobenjn text classification resource

Verified brave.com was classified

[22081:22081:0524/125239.227647:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[22081:22081:0524/125324.450420:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

"purchaseIntentSignalHistory": {
		"BF001": [{
				"timestamp_in_seconds": 1621835632,
				"weight": 1
			}
		],
		"Crypto Purchase Intent": [{
				"timestamp_in_seconds": 1621835632,
				"weight": 1
			}
		]
	},

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[22081:22081:0524/125324.640078:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[22081:22081:0524/125324.640124:VERBOSE1:ad_notification_serving.cc(176)]   technology & computing-technology & computing
[22081:22081:0524/125324.640160:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[22081:22081:0524/125324.640182:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[22081:22081:0524/125324.640212:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[22081:22081:0524/125324.640232:VERBOSE1:ad_notification_serving.cc(176)]   BF001
[22081:22081:0524/125324.642572:VERBOSE1:ad_notification_serving.cc(190)] No eligible ads found for segments
[22081:22081:0524/125324.642726:VERBOSE1:ad_notification_serving.cc(206)] Serve ad for parent segments:
[22081:22081:0524/125324.642846:VERBOSE1:ad_notification_serving.cc(208)]   technology & computing
[22081:22081:0524/125324.642991:VERBOSE1:ad_notification_serving.cc(208)]   personal finance
[22081:22081:0524/125324.643118:VERBOSE1:ad_notification_serving.cc(208)]   Crypto Purchase Intent
[22081:22081:0524/125324.643231:VERBOSE1:ad_notification_serving.cc(208)]   BF001

Verified 1.24.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.29 was downloaded
image

Verified resources were loaded

[24521:24521:0524/130303.132935:VERBOSE1:user_model_file_service.cc(103)] Registering Brave User Model Installer (US) with id kkjipiepeooghlclkedllogndmohhnhi
[24521:24521:0524/130303.133024:VERBOSE1:user_model_file_service.cc(122)] Registering Brave User Model Installer (en) with id emgmepnebbddgnkhfmhdhmjifkglkamo


[24521:24521:0524/130303.904360:VERBOSE1:user_model_file_service.cc(210)] Adding kkjipiepeooghlclkedllogndmohhnhi user model
[24521:24521:0524/130303.904386:VERBOSE1:user_model_file_service.cc(210)] Adding mkdhnfmjhklfnamlheoliekgeohamoig user model
[24521:24521:0524/130303.904398:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[24521:24521:0524/130303.905410:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/kkjipiepeooghlclkedllogndmohhnhi/1.0.29/kkjipiepeooghlclkedllogndmohhnhi
[24521:24521:0524/130303.905454:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/kkjipiepeooghlclkedllogndmohhnhi/1.0.29/xgauimuqostzbswdrrduxadfbhwrngio
[24521:24521:0524/130303.908086:VERBOSE1:purchase_intent_resource.cc(54)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[24521:24521:0524/130303.908129:VERBOSE1:purchase_intent_resource.cc(229)] Parsed purchase intent user model version 1
[24521:24521:0524/130303.908169:VERBOSE1:purchase_intent_resource.cc(64)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[24521:24521:0524/130303.908189:VERBOSE1:anti_targeting_resource.cc(42)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[24521:24521:0524/130303.908238:VERBOSE1:anti_targeting_resource.cc(114)] Parsed anti targeting resource version 1
[24521:24521:0524/130303.908272:VERBOSE1:anti_targeting_resource.cc(52)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[24521:24521:0524/130304.341253:VERBOSE1:user_model_file_service.cc(210)] Adding emgmepnebbddgnkhfmhdhmjifkglkamo user model
[24521:24521:0524/130304.341300:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[24521:24521:0524/130304.348415:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /home/bartlomiej/.config/BraveSoftware/Brave-Browser/emgmepnebbddgnkhfmhdhmjifkglkamo/1.0.29/emgmepnebbddgnkhfmhdhmjifkglkamo
[24521:24521:0524/130304.476555:VERBOSE1:text_classification_resource.cc(55)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo text classification resource

Verified brave.com was classified

[24521:24521:0524/130904.590141:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[24521:24521:0524/131020.834996:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

	"purchaseIntentSignalHistory": {
		"BF001": [{
				"timestamp_in_seconds": 1621854620,
				"weight": 1
			}
		],
		"Crypto Purchase Intent": [{
				"timestamp_in_seconds": 1621854620,
				"weight": 1
			}
		]
	},

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[24521:24521:0524/131649.467599:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[24521:24521:0524/131649.467675:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[24521:24521:0524/131649.467777:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[24521:24521:0524/131649.467833:VERBOSE1:ad_notification_serving.cc(176)]   science-economics
[24521:24521:0524/131649.467897:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[24521:24521:0524/131649.467966:VERBOSE1:ad_notification_serving.cc(176)]   BF001
[24521:24521:0524/131649.468767:VERBOSE1:ad_notification_serving.cc(190)] No eligible ads found for segments
[24521:24521:0524/131649.468850:VERBOSE1:ad_notification_serving.cc(206)] Serve ad for parent segments:
[24521:24521:0524/131649.468906:VERBOSE1:ad_notification_serving.cc(208)]   personal finance
[24521:24521:0524/131649.469022:VERBOSE1:ad_notification_serving.cc(208)]   science
[24521:24521:0524/131649.469076:VERBOSE1:ad_notification_serving.cc(208)]   Crypto Purchase Intent
[24521:24521:0524/131649.469141:VERBOSE1:ad_notification_serving.cc(208)]   BF001

Verified using

Brave | 1.25.66 Chromium: 91.0.4472.70 (Official Build) (x86_64)
-- | --
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | macOS Version 10.15.7 (Build 19H1030)

Used en_US locale

Verified 1.25.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.2 was downloaded

Example Example Example
1 25 x component 1 1 25 x component 2 1 25 x component 3

Verified resources were loaded

[7229:775:0524/170042.834520:VERBOSE1:resource_component.cc(104)] Registering Brave Ads Resources (US) with id iblokdlgekdjophgeonmanpnjihcjkjj
[7229:775:0524/170042.834622:VERBOSE1:resource_component.cc(123)] Registering Brave Ads Resources (en) with id ocilmpijebaopmdifcomolmpigakocmo

[7229:775:0524/170043.067836:VERBOSE1:resource_component.cc(212)] Adding resource bejenkminijgplakmkmcgkhjjnkelbld version 1
[7229:775:0524/170043.067863:VERBOSE1:resource_component.cc(212)] Adding resource mkdhnfmjhklfnamlheoliekgeohamoig version 1
[7229:775:0524/170043.067880:VERBOSE1:resource_component.cc(218)] Notifying resource observers
[7229:775:0524/170043.071044:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.2/kkjipiepeooghlclkedllogndmohhnhi
[7229:775:0524/170043.071198:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.2/xgauimuqostzbswdrrduxadfbhwrngio
[7229:775:0524/170043.072362:VERBOSE1:purchase_intent_resource.cc(44)] Successfully loaded bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[7229:775:0524/170043.075183:VERBOSE1:purchase_intent_resource.cc(221)] Parsed purchase intent resource version 1
[7229:775:0524/170043.075669:VERBOSE1:purchase_intent_resource.cc(56)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[7229:775:0524/170043.075733:VERBOSE1:anti_targeting_resource.cc(43)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[7229:775:0524/170043.075773:VERBOSE1:anti_targeting_resource.cc(115)] Parsed anti targeting resource version 1
[7229:775:0524/170043.075810:VERBOSE1:anti_targeting_resource.cc(53)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig

Verified brave.com was classified

[7229:775:0524/170614.464018:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[7229:775:0524/170710.994988:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

  "purchaseIntentSignalHistory": {
    "BF001": [
      {
        "timestamp_in_seconds": 1621890430,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621890431,
        "weight": 1
      }
    ],
    "Crypto Purchase Intent": [
      {
        "timestamp_in_seconds": 1621890430,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621890431,
        "weight": 1
      }
    ]
  },

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[9028:775:0525/095129.323513:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[9028:775:0525/095129.323578:VERBOSE1:ad_notification_serving.cc(176)]   technology & computing-software
[9028:775:0525/095129.323615:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[9028:775:0525/095129.323648:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[9028:775:0525/095129.323681:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[9028:775:0525/095129.323713:VERBOSE1:ad_notification_serving.cc(176)]   BF001

Verified 1.24.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.30 was downloaded

Example Example Example
1 24 x component 1 1 24 x component 2 1 24 x component 3

Verified resources were loaded

[7373:775:0524/172007.336137:VERBOSE1:user_model_file_service.cc(103)] Registering Brave User Model Installer (US) with id kkjipiepeooghlclkedllogndmohhnhi
[7373:775:0524/172007.336237:VERBOSE1:user_model_file_service.cc(122)] Registering Brave User Model Installer (en) with id emgmepnebbddgnkhfmhdhmjifkglkamo

[7373:775:0524/172007.552121:VERBOSE1:user_model_file_service.cc(210)] Adding kkjipiepeooghlclkedllogndmohhnhi user model
[7373:775:0524/172007.552178:VERBOSE1:user_model_file_service.cc(210)] Adding mkdhnfmjhklfnamlheoliekgeohamoig user model
[7373:775:0524/172007.552205:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[7373:775:0524/172007.653790:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser/kkjipiepeooghlclkedllogndmohhnhi/1.0.30/kkjipiepeooghlclkedllogndmohhnhi
[7373:775:0524/172007.653881:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser/kkjipiepeooghlclkedllogndmohhnhi/1.0.30/xgauimuqostzbswdrrduxadfbhwrngio
[7373:775:0524/172007.736340:VERBOSE1:user_model_file_service.cc(210)] Adding emgmepnebbddgnkhfmhdhmjifkglkamo user model
[7373:775:0524/172007.736381:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[7373:775:0524/172007.739663:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from /Users/lauren/Library/Application Support/BraveSoftware/Brave-Browser/emgmepnebbddgnkhfmhdhmjifkglkamo/1.0.30/emgmepnebbddgnkhfmhdhmjifkglkamo
[7373:775:0524/172007.926088:VERBOSE1:purchase_intent_resource.cc(54)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[7373:775:0524/172007.927779:VERBOSE1:purchase_intent_resource.cc(229)] Parsed purchase intent user model version 1
[7373:775:0524/172007.928876:VERBOSE1:purchase_intent_resource.cc(64)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[7373:775:0524/172007.929010:VERBOSE1:anti_targeting_resource.cc(42)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[7373:775:0524/172007.929080:VERBOSE1:anti_targeting_resource.cc(114)] Parsed anti targeting resource version 1
[7373:775:0524/172007.929143:VERBOSE1:anti_targeting_resource.cc(52)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[7373:775:0524/172007.945184:VERBOSE1:text_classification_resource.cc(55)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo text classification resource
[7373:775:0524/172008.225034:VERBOSE1:database_publisher_prefix_list.cc(133)] Inserting 100000 records into publisher prefix table
[7373:775:0524/172008.451692:VERBOSE1:text_classification_resource.cc(63)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo text classification resource

Verified brave.com was classified

[7373:775:0524/172317.079200:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[7373:775:0524/172432.770531:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

  "purchaseIntentSignalHistory": {
    "BF001": [
      {
        "timestamp_in_seconds": 1621891472,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621891472,
        "weight": 1
      }
    ],
    "Crypto Purchase Intent": [
      {
        "timestamp_in_seconds": 1621891472,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621891472,
        "weight": 1
      }
    ]
  },

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[9225:775:0525/101109.571272:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[9225:775:0525/101109.571327:VERBOSE1:ad_notification_serving.cc(176)]   technology & computing-software
[9225:775:0525/101109.571367:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[9225:775:0525/101109.571403:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[9225:775:0525/101109.571440:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[9225:775:0525/101109.571475:VERBOSE1:ad_notification_serving.cc(176)]   BF001

Verification passed on



<!--StartFragment-->
Brave | 1.25.66 Chromium: 91.0.4472.70&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Used en_US locale

Verified 1.25.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.2 was downloaded

Example Example Example Example
image image image image

Verified resources were loaded

[11692:12972:0525/152235.437:VERBOSE1:resource_component.cc(104)] Registering Brave Ads Resources (US) with id iblokdlgekdjophgeonmanpnjihcjkjj
[11692:12972:0525/152235.439:VERBOSE1:resource_component.cc(123)] Registering Brave Ads Resources (en) with id ocilmpijebaopmdifcomolmpigakocmo

[11692:12972:0525/152235.457:VERBOSE1:resource_component.cc(212)] Adding resource bejenkminijgplakmkmcgkhjjnkelbld version 1
[11692:12972:0525/152235.458:VERBOSE1:resource_component.cc(212)] Adding resource mkdhnfmjhklfnamlheoliekgeohamoig version 1
[11692:12972:0525/152235.474:VERBOSE1:resource_component.cc(218)] Notifying resource observers
[11692:12972:0525/152235.476:VERBOSE8:resource_component.cc(153)] resource manifest: {"schemaVersion":1,"resources":[{"id":"feibnmjhecfbjpeciancnchbmlobenjn","filename":"emgmepnebbddgnkhfmhdhmjifkglkamo","version":1,"status":"stable"}]}
[11692:12972:0525/152235.489:VERBOSE1:resource_component.cc(212)] Adding resource feibnmjhecfbjpeciancnchbmlobenjn version 1
[11692:12972:0525/152235.490:VERBOSE1:resource_component.cc(218)] Notifying resource observers
[11692:12972:0525/152235.570:VERBOSE1:epsilon_greedy_bandit_processor.cc(124)] Successfully initialized epsilon greedy bandit arms
[11692:12972:0525/152235.571:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\iblokdlgekdjophgeonmanpnjihcjkjj\1.0.2\kkjipiepeooghlclkedllogndmohhnhi
[11692:12972:0525/152235.572:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\iblokdlgekdjophgeonmanpnjihcjkjj\1.0.2\xgauimuqostzbswdrrduxadfbhwrngio
[11692:12972:0525/152235.572:VERBOSE1:ads_impl.cc(268)] Successfully set wallet
[11692:12972:0525/152235.573:VERBOSE1:ads_service_impl.cc(1910)] Loading ads resource from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\ocilmpijebaopmdifcomolmpigakocmo\1.0.2\emgmepnebbddgnkhfmhdhmjifkglkamo
[11692:12972:0525/152235.584:ERROR:os_crypt_win.cc(93)] Failed to decrypt: The parameter is incorrect. (0x57)
[11692:12972:0525/152235.584:ERROR:gemini_service.cc(418)] Could not decrypt and save Gemini access token
[11692:12972:0525/152235.590:VERBOSE1:ads_impl.cc(98)] Initializing ads
[11692:12972:0525/152235.595:VERBOSE1:purchase_intent_resource.cc(44)] Successfully loaded bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[11692:12972:0525/152235.601:VERBOSE1:purchase_intent_resource.cc(221)] Parsed purchase intent resource version 1
[11692:12972:0525/152235.602:VERBOSE1:purchase_intent_resource.cc(56)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource
[11692:12972:0525/152235.602:VERBOSE1:anti_targeting_resource.cc(43)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[11692:12972:0525/152235.603:VERBOSE1:anti_targeting_resource.cc(115)] Parsed anti targeting resource version 1
[11692:12972:0525/152235.604:VERBOSE1:anti_targeting_resource.cc(53)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig

Verified brave.com was classified

[11692:12972:0525/152322.723:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[5832:11696:0525/151627.720:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

"purchaseIntentSignalHistory": {
    "BF001": [
      {
        "timestamp_in_seconds": 1621935987,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621935987,
        "weight": 1
      }
    ],
    "Crypto Purchase Intent": [
      {
        "timestamp_in_seconds": 1621935987,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621935987,
        "weight": 1
      }
    ]
  },

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[8724:11504:0525/155217.854:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[8724:11504:0525/155217.858:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[8724:11504:0525/155217.859:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[8724:11504:0525/155217.864:VERBOSE1:ad_notification_serving.cc(176)]   business-business
[8724:11504:0525/155217.866:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[8724:11504:0525/155217.876:VERBOSE1:ad_notification_serving.cc(176)]   BF001
[8724:11504:0525/155217.880:VERBOSE1:ad_notification_serving.cc(190)] No eligible ads found for segments
[8724:11504:0525/155217.880:VERBOSE1:ad_notification_serving.cc(206)] Serve ad for parent segments:
[8724:11504:0525/155217.880:VERBOSE1:ad_notification_serving.cc(208)]   personal finance
[8724:11504:0525/155217.892:VERBOSE1:ad_notification_serving.cc(208)]   business
[8724:11504:0525/155217.892:VERBOSE1:ad_notification_serving.cc(208)]   Crypto Purchase Intent
[8724:11504:0525/155217.893:VERBOSE1:ad_notification_serving.cc(208)]   BF001

Verified 1.24.x

cmd params used:

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6

Verified version 1.0.30 was downloaded

Example Example Example Example
image image image image

Verified resources were loaded

[20048:4664:0525/160423.059:VERBOSE1:user_model_file_service.cc(103)] Registering Brave User Model Installer (US) with id kkjipiepeooghlclkedllogndmohhnhi
[20048:4664:0525/160423.059:VERBOSE1:user_model_file_service.cc(122)] Registering Brave User Model Installer (en) with id emgmepnebbddgnkhfmhdhmjifkglkamo

[20048:4664:0525/160424.578:VERBOSE1:user_model_file_service.cc(210)] Adding kkjipiepeooghlclkedllogndmohhnhi user model
[20048:4664:0525/160424.578:VERBOSE1:user_model_file_service.cc(210)] Adding mkdhnfmjhklfnamlheoliekgeohamoig user model
[20048:4664:0525/160424.580:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[20048:4664:0525/160424.580:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\kkjipiepeooghlclkedllogndmohhnhi\1.0.30\kkjipiepeooghlclkedllogndmohhnhi
[20048:4664:0525/160424.581:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\kkjipiepeooghlclkedllogndmohhnhi\1.0.30\xgauimuqostzbswdrrduxadfbhwrngio
[20048:4664:0525/160424.586:VERBOSE1:purchase_intent_resource.cc(54)] Successfully loaded kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[20048:4664:0525/160424.590:VERBOSE1:purchase_intent_resource.cc(229)] Parsed purchase intent user model version 1
[20048:4664:0525/160424.590:VERBOSE1:purchase_intent_resource.cc(64)] Successfully initialized kkjipiepeooghlclkedllogndmohhnhi purchase intent resource
[20048:4664:0525/160424.591:VERBOSE1:anti_targeting_resource.cc(42)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[20048:4664:0525/160424.592:VERBOSE1:anti_targeting_resource.cc(114)] Parsed anti targeting resource version 1
[20048:4664:0525/160424.593:VERBOSE1:anti_targeting_resource.cc(52)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig
[20048:4664:0525/160425.192:VERBOSE1:user_model_file_service.cc(210)] Adding emgmepnebbddgnkhfmhdhmjifkglkamo user model
[20048:4664:0525/160425.192:VERBOSE1:user_model_file_service.cc(215)] Notifying user model observers
[20048:4664:0525/160425.195:VERBOSE1:ads_service_impl.cc(1894)] Loading user model from C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser\User Data\emgmepnebbddgnkhfmhdhmjifkglkamo\1.0.30\emgmepnebbddgnkhfmhdhmjifkglkamo
[20048:4664:0525/160425.249:VERBOSE1:text_classification_resource.cc(55)] Successfully loaded emgmepnebbddgnkhfmhdhmjifkglkamo text classification resource
[20048:4664:0525/160425.764:VERBOSE1:text_classification_resource.cc(63)] Successfully initialized emgmepnebbddgnkhfmhdhmjifkglkamo text classification resource

Verified brave.com was classified

[20048:4664:0525/160736.972:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software

Verified that purchase intent is extracted from https://finance.yahoo.com

[20048:4664:0525/160917.870:VERBOSE1:purchase_intent_processor.cc(99)] Extracted purchase intent signal from visited URL

Verified purchase intent signal was added to client.json

"purchaseIntentSignalHistory": {
    "BF001": [
      {
        "timestamp_in_seconds": 1621939156,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621939157,
        "weight": 1
      }
    ],
    "Crypto Purchase Intent": [
      {
        "timestamp_in_seconds": 1621939156,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1621939157,
        "weight": 1
      }
    ]
  },

Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments

[620:13272:0525/161743.308:VERBOSE1:ad_notification_serving.cc(174)] Serve ad for segments:
[620:13272:0525/161743.311:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-investing
[620:13272:0525/161743.313:VERBOSE1:ad_notification_serving.cc(176)]   personal finance-personal finance
[620:13272:0525/161743.319:VERBOSE1:ad_notification_serving.cc(176)]   technology & computing-software
[620:13272:0525/161743.321:VERBOSE1:ad_notification_serving.cc(176)]   Crypto Purchase Intent
[620:13272:0525/161743.326:VERBOSE1:ad_notification_serving.cc(176)]   BF001
[620:13272:0525/161743.329:VERBOSE1:ad_notification_serving.cc(190)] No eligible ads found for segments
[620:13272:0525/161743.334:VERBOSE1:ad_notification_serving.cc(206)] Serve ad for parent segments:
[620:13272:0525/161743.335:VERBOSE1:ad_notification_serving.cc(208)]   personal finance
[620:13272:0525/161743.338:VERBOSE1:ad_notification_serving.cc(208)]   technology & computing
[620:13272:0525/161743.346:VERBOSE1:ad_notification_serving.cc(208)]   Crypto Purchase Intent
[620:13272:0525/161743.347:VERBOSE1:ad_notification_serving.cc(208)]   BF001

@btlechowski btlechowski added QA Pass-Linux QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 24, 2021
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.68 x64 build

  • Verified Brave Ads Resource v1.0.2 is downloaded

  • Verified Resources were loaded correctly
    image
    image

  • Verified https://brave.com gets classified as technolgy
    image

  • Verified visiting https://finance.yahoo.com shows extacting purchase intent
    image

  • Verified resources load for both old and new versions
    image

  • Verified purchase intent segments (Crypto Purchase Intent, BF001) were added to ads segments
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moritzhaller moritzhaller

Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Enhance and refactor the Brave Ads component updater brave/brave-core
6 participants
@tmancey @moritzhaller @srirambv @LaurenWags @btlechowski @GeetaSarvadnya