-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not redirect in IPFS network delegate when resolve method is disabled or IPFS is disabled or in private/guest windows #12978
Comments
full test plan is specified in brave/brave-core#7307 |
Verified passed with
Verified test plan from brave/brave-core#7307 (comment) Method to resolve IPFS resources=GatewaySet "Method to resolve IPFS resources" to "Gateway" in settings: Confirmed visiting provided URL, Confirmed visiting provided URL, Confirmed visiting provided URL, Confirmed visiting provided URL, Method to resolve IPFS resources=DisabledSet "Method to resolve IPFS resources" to "Disabled" in settings: Confirmed visiting provided URL, Also confirmed visiting provided URL in Private, Guest, and Tor windows does not resolve. Verification passed on
Verified test plan from brave/brave-core#7307 (comment) Method to resolve IPFS resources=GatewaySet "Method to resolve IPFS resources" to "Gateway" in settings: Confirmed visiting provided URL, Confirmed visiting provided URL, Confirmed visiting provided URL, Confirmed visiting provided URL, Method to resolve IPFS resources=DisabledSet "Method to resolve IPFS resources" to "Disabled" in settings: Confirmed visiting provided URL, Confirmed visiting provided URL in Private, Guest, and Tor windows does not resolve. Verification passed on
Verified test plan from brave/brave-core#7307 (comment) |
Description
Follow-up of brave/brave-core#7194.
OnBeforeURLRequest_IPFSRedirectWork
inbrowser/net/ipfs_redirect_network_delegate_helper.cc
should check if IPFS resolve method and the feature itself is enabled or not before doing the redirect.Steps to Reproduce
Actual result:
URL is redirected to https://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi.ipfs.dweb.link/.
Expected result:
URL should not be redirected.
Reproduces how often:
Every time.
Brave version (brave://version info)
Nightly
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: