Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewards setup panel to onboarding tour #13379

Closed
zenparsing opened this issue Jan 5, 2021 · 1 comment · Fixed by brave/brave-core#7525
Closed

Add rewards setup panel to onboarding tour #13379

zenparsing opened this issue Jan 5, 2021 · 1 comment · Fixed by brave/brave-core#7525

Comments

@zenparsing
Copy link

The setup panel should allow the user to adjust the "ads per day" and "monthly AC amount" settings:

Screen Shot 2021-01-05 at 4 43 12 PM

The panel should only be displayed after the user has opted-in by clicking the "Start Using Rewards" button. It should not be displayed if the user is simply previewing the tour or viewing the tour again after enabling rewards.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 15, 2021

Verified using

Brave	1.21.54 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 10.15.7 (Build 19H512)

Verified test plan from brave/brave-core#7525

Rewards Panel

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
panel - default panel - update settings panel - settings
Rewards page

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
page-default page - update settings page-settings
Tip Dialog

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
tip-default tip-update settings tip-settings

Verification passed on


Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from brave/brave-core#7525

Rewards Panel

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image
Rewards page

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image
Tip Dialog

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image

Verification passed on

Brave 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7525

Rewards Panel

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image
Rewards page

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image
Tip Dialog

Confirmed quick tour does not contain settings slide.
Confirmed tour shown after clicking on "Start using Brave Rewards" does contain settings slide.
Confirmed able to modify the selections on the settings slide.
Confirmed selections are reflected on brave://rewards page.

Setting slide with default values Updated settings via slide Selections retained on brave://rewards
image image image

Logged #14368 for missing translations

@rebron rebron changed the title [Desktop] Add rewards setup panel to onboarding tour Add rewards setup panel to onboarding tour Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment