Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more options for "Send Tab" #13461

Open
eljuno opened this issue Jan 10, 2021 · 2 comments
Open

Provide more options for "Send Tab" #13461

eljuno opened this issue Jan 10, 2021 · 2 comments
Labels
feature/sync feature-request OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@eljuno
Copy link

eljuno commented Jan 10, 2021

Description

Note: I only tested this using 1 desktop (Nightly) and 1 Android device (Stable and Nightly). So I'm not aware about the behavior with more devices.

On desktop, when you trying to send tab to other device, you only presented with the device name, unlike Android version which give you more option to send to specific installation.

Steps to Reproduce

  1. On desktop, open any site
  2. Send tab via right-click or right-click on tab
  3. Only presented with one option

Actual result:

send-tab-dekstop

Expected result:

More options like Android version

IMG_20210111_042203

Reproduces how often:

Easy

Brave version (brave://version info)

Desktop and Android (Nightly)
Brave 1.20.70 Chromium: 88.0.4324.79 (Official Build) nightly (64-bit)

Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}

Android (Stable)
Brave 1.18.77 Chromium: 87.0.4280.101 (Official Build) (32-bit)

Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES, (only tested on Android)
  • Can you reproduce this issue with the beta channel? NDA
  • Can you reproduce this issue with the nightly channel? YES

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome?

NDA

Miscellaneous Information:

NDA

@eljuno
Copy link
Author

eljuno commented Jan 24, 2021

Added Beta build to the same sync chain on the same laptop. Same behavior. Now, there's no choice to send tab to mobile.

tab-share-beta

@rebron rebron added feature-request priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 19, 2021
@AlexeyBarabash
Copy link
Contributor

This happened because when in the same Sync chain there are two browser from the same device, they both have the same name. And the code which gives the destination where to send the open tab picks only the first.

With #11769 the issue will not appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync feature-request OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: Untriaged backlog
Development

No branches or pull requests

3 participants