Fix database upgrade paths for iOS #13495
Assignees
Labels
bug
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
tmancey
added
bug
priority/P2
tmancey
changed the title
tmancey
changed the title
This was referenced Jan 12, 2021
tmancey
added
release-notes/exclude
OS/iOS
kjozwiak
added
OS/Android
|
@tmancey assuming this should also be checked on |
|
Verification passed on OnePlus 6T with Android 10 running 1.19.87 x64 build
13495.mp4Verification passed on Samsung Tab A with Android 10 running 1.19.87 x64 build
13495-Tab.mp4 |
|
Verification PASSED on
|
| Brave | 1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit) |
|---|---|
| Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
| OS | Ubuntu 18.04 LTS |
Test Case 1 (ensuring rewards working on 1.19.88 CR: 88.0.4324.96)
- ensured that both NTP SI/Ad notifications are working and
brave://rewardsis being updated - ensured that connecting a KYC's/Verified account worked without any issues
- ensured that tipping was working as expected
NTP SI logs
[5396:5396:0128/151046.594600:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 2f32fecc-a15d-4179-a536-15fc16607c59 and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
[5396:5396:0128/151047.147075:VERBOSE1:confirmations.cc(228)] Successfully redeemed unblinded token with confirmation id cd70633d-deea-497b-bea9-19c581f215f2, creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4 and view
[5396:5396:0128/151047.147413:VERBOSE1:confirmations.cc(249)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens
Ad notification logs
[5396:5396:0128/151235.346558:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: 25d17372-0415-4043-9435-7fead9f0fead
creativeInstanceId: f67f71aa-6e08-4c75-b303-522a4468a5f7
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Nexo's Earn on Crypto
body: Get 8% APY on your crypto assets, paid out daily.
[5396:5396:0128/151235.913238:VERBOSE1:confirmations.cc(249)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 2 unblinded payment tokens
Test Case 2 (upgrading from 1.17.x to 1.19.88 CR: 88.0.4324.96)
Ads Enabled
- downloaded/installed
1.17.75 CR: 87.0.4280.88and enabled ads viabrave://rewards - viewed both a NTP SI & ad notification and ensured that
Estimated pending rewards,Ads received this monthand7-day Ads Historywere being updated - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that the data from
1.17.75 CR: 87.0.4280.88was still presentEstimated pending rewards,Ads received this monthand7-day Ads History
- ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
NTP SI logs
[10193:10193:0128/153430.963480:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 0c5c73b2-2df6-40c2-acdb-a874c30fbfd0 and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
[10193:10193:0128/153431.536801:VERBOSE1:confirmations.cc(228)] Successfully redeemed unblinded token with confirmation id ec966b3e-4079-4f3e-acbc-9c180b3a292e, creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4 and view
[10193:10193:0128/153431.537061:VERBOSE1:confirmations.cc(249)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 4 unblinded payment tokens
Ad notification logs
[10193:10193:0128/153837.871290:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: 640a20f6-6c7b-4906-b322-997649c71f52
creativeInstanceId: 9867a588-d9f8-4c03-a5db-9434184b018c
creativeSetId: 46fa3850-f600-4d3a-a46e-b8cb6653bcd8
campaignId: d4a1c3ed-b1aa-46b5-b8bf-e2cc34d6af9d
category: untargeted
title: Tired of Gmail spying on you?
body: Try ProtonMail, the secure email that respects your privacy.
targetUrl: https://go.getproton.me/aff_c?offer_id=15&aff_id=1397
[10193:10193:0128/153837.876785:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 640a20f6-6c7b-4906-b322-997649c71f52 and creative instance id 9867a588-d9f8-4c03-a5db-9434184b018c
Ads Disabled
- installed
1.17.75 CR: 87.0.4280.88and disabled ads viabrave://rewards - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that ads were still disabled via
brave://rewards - enabled ads via
brave://rewards - ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
NTP SI logs
[12364:12364:0128/154331.247183:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 425b80ec-98fd-4751-acec-647074dd6d5c and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
Ad notification logs
[12364:12364:0128/154511.919403:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: 7bddfd51-dc5f-424b-867a-b276f628c389
creativeInstanceId: 84fcbc27-300d-4d10-a98c-367fcb1896d8
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Earn on Crypto with Nexo
body: Earn up to 8% Interest on Bitcoin & Ethereum.
Test Case 3 (upgrading from 1.18.x to 1.19.88 CR: 88.0.4324.96)
Ads Enabled
- downloaded/installed
1.18.78 CR: 87.0.4280.141and enabled ads viabrave://rewards - viewed both a NTP SI & ad notification and ensured that
Estimated pending rewards,Ads received this monthand7-day Ads Historywere being updated - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that the data from
1.18.78 CR: 87.0.4280.141was still presentEstimated pending rewards,Ads received this monthand7-day Ads History
- ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
NTP SI logs
[12806:12806:0128/154725.148726:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid ad1649b2-3306-4d64-bb2f-65eae26b05ee and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
Ad notification logs
[12806:12806:0128/155928.938968:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: 8a52434d-62fa-478f-a528-3f18c30f1be4
creativeInstanceId: a5a4333d-4e9d-4d1b-9504-0184e626efa6
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Save with Nexo
Ads Disabled
- installed
1.18.78 CR: 87.0.4280.141and disabled ads viabrave://rewards - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that ads were still disabled via
brave://rewards - enabled ads via
brave://rewards - ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
NTP SI logs
[13277:13277:0128/160104.811481:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 0af29c1c-2685-4d97-a11e-5e5ada7e6897 and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
Ad notification logs
[13277:13277:0128/160213.761573:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: b18e8a91-c05f-4547-992c-5e1fa843cf6e
creativeInstanceId: abae02bb-001d-4211-8943-d8c01e3ab2c1
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Nexo’s Savings Account
body: Earn up to 8% APY with compounding interest, paid out daily.
Test Case 4 (upgrading from 1.19.86 CR: 88.0.4324.96 to 1.19.88 CR: 88.0.4324.96)
Ads Enabled
- downloaded/installed
1.19.86 CR: 88.0.4324.96and enabled ads viabrave://rewards - viewed both a NTP SI & ad notification and ensured that
Estimated pending rewards,Ads received this monthand7-day Ads Historywere being updated - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that the data from
1.19.86 CR: 88.0.4324.96was still presentEstimated pending rewards,Ads received this monthand7-day Ads History
- ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
NTP SI logs
[13710:13710:0128/160414.974327:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 641dad0e-426f-463b-9a2d-b7e4cde84212 and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
Ad notification logs
[13710:13710:0128/160600.964316:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: fb18d611-9054-4c37-8aa8-cc97e93693e9
creativeInstanceId: 15e1e052-e0db-4629-a4ce-1aeaab6e92f1
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Save with Nexo
body: Up to 8% APY on BTC & ETH, with daily pay outs.
Ads Disabled
- installed
1.18.78 CR: 87.0.4280.141and disabled ads viabrave://rewards - Upgraded to
1.19.88 CR: 88.0.4324.96and launched Brave - ensured that ads were still disabled via
brave://rewards - enabled ads via
brave://rewards - ensured that viewing a NTP SI ad was working and
brave://rewardswas being updated - ensured that viewing an ad notification was working and
brave://rewardswas being updated
Encountered #13815
NTP SI logs
Was not rewarded for NTP SI
[7494:7494:0128/151803.807719:INFO:creative_new_tab_page_ads_database_table.cc(426)] Failed to get creative new tab page ad
[7494:7494:0128/151803.808073:VERBOSE1:new_tab_page_ad.cc(77)] Failed to fire new tab page ad event for wallpaper id
Issue was fixed after browser restart
[14159:14159:0128/160959.141510:VERBOSE3:new_tab_page_ad_event_viewed.cc(26)] Viewed new tab page ad with uuid 76b82841-9786-4ed8-bfdc-ea0bddef1cdc and creative instance id ae0843a5-2859-45ed-be26-b91bd08420b4
Ad notification logs
Was unable to view ads
[7494:7494:0128/152037.687266:VERBOSE1:ad_notification_serving.cc(242)] No eligible ads found for untargeted category
[7494:7494:0128/152037.687338:VERBOSE1:ad_notification_serving.cc(243)] Ad notification not served: No eligible ads found
Issue was fixed after browser restart
[14159:14159:0128/161126.889501:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
uuid: 74e5e773-5f53-49a3-b135-ee32de5d2fa6
creativeInstanceId: e5a7f7d5-b93d-443e-ab07-21fcf096bb83
creativeSetId: dce1b0d8-cf10-410e-936f-96b2a0b84e00
campaignId: 028af44e-dca7-4f50-97b0-31b2aa8d0bcc
category: untargeted
title: Nexo 12% Fiat Savings Account
body: Enjoy up to 12% APY on your USD, EUR and GBP with Nexo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Brave Ads are not shown on iOS
Steps to Reproduce
Actual result:
Ad is not shown
Expected result:
Ad should be shown
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The fix affects the upgrade paths for both desktop and mobile
The text was updated successfully, but these errors were encountered: